Skip to content

Remove Shadow JAR dependency #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Remove Shadow JAR dependency #5330

wants to merge 4 commits into from

Conversation

Big-Iron-Cheems
Copy link
Collaborator

Type of change

  • Bug fix
  • New feature

Description

Remove Shadow JAR dependency, in favour of JAR-in-JAR packaging.

Related issues

None.

How Has This Been Tested?

N/A.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@Big-Iron-Cheems
Copy link
Collaborator Author

FIXME: deps not working outside of dev env

@Big-Iron-Cheems Big-Iron-Cheems marked this pull request as draft April 20, 2025 22:48
@MukjepScarlet
Copy link

MukjepScarlet commented Jul 7, 2025 •
edited
Loading

include of Fabric Loom doesn't handle transitive libs. You can see another way here: https://github.com/CCBlueX/LiquidBounce/blob/nextgen/build.gradle.kts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Big-Iron-Cheems @MukjepScarlet