-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #100
Update README.md #100
Conversation
Update Readme to reflect that the Japan version of buddies plus is supported
审阅者指南 by Sourcery此拉取请求更新了 README.md 文件,以反映现在支持日本版 MaiMai DX。版本号已从 1.40 更新到 1.45,代号也从 BUDDiES 更新到 BUDDiES PLUS。 MaiMai DX 版本更新状态图stateDiagram-v2
BUDDiES_140: MaiMai DX v1.40 (BUDDiES)
BUDDiES_PLUS_145: MaiMai DX v1.45 (BUDDiES PLUS)
BUDDiES_140 --> BUDDiES_PLUS_145: 版本更新
note right of BUDDiES_PLUS_145
日本版现在与
国际版匹配
end note
文件级别变更
提示和命令与 Sourcery 交互
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request updates the README.md file to reflect that the Japan version of MaiMai DX is now supported. The version number has been updated from 1.40 to 1.45 and the codename has been updated from BUDDiES to BUDDiES PLUS. State diagram for MaiMai DX version updatestateDiagram-v2
BUDDiES_140: MaiMai DX v1.40 (BUDDiES)
BUDDiES_PLUS_145: MaiMai DX v1.45 (BUDDiES PLUS)
BUDDiES_140 --> BUDDiES_PLUS_145: Version Update
note right of BUDDiES_PLUS_145
Japan version now matches
International version
end note
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @thewiilover - 我已经审查了你的更改 - 以下是一些反馈:
整体评论:
- 'BUDDiES PLUS'(两个空格)和 'BUDDiES PLUS'(一个空格)的间距不一致 - 请标准化为单词之间的单一间距
以下是我在审查期间查看的内容
- 🟡 一般问题:发现1个问题
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @thewiilover - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's an inconsistent spacing in 'BUDDiES PLUS' (two spaces) vs 'BUDDiES PLUS' (one space) - please standardize to single spacing between words
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Lol thanks |
The ocd kicked immediately |
Update Readme to reflect that the Japan version of buddies plus is supported.
I guess I wasn't kidding when I said "Readme update here I come"
Summary by Sourcery
文档:
Original summary in English
Summary by Sourcery
Documentation: