Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #100

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Update README.md #100

merged 2 commits into from
Jan 4, 2025

Conversation

thewiilover
Copy link
Contributor

@thewiilover thewiilover commented Jan 3, 2025

Update Readme to reflect that the Japan version of buddies plus is supported.
I guess I wasn't kidding when I said "Readme update here I come"

Summary by Sourcery

文档:

  • 更新 README.md 以反映 MaiMai DX 的支持版本。
Original summary in English

Summary by Sourcery

Documentation:

  • Update README.md to reflect the supported version of MaiMai DX.

Update Readme to reflect that the Japan version of buddies plus is supported
Copy link
Contributor

sourcery-ai bot commented Jan 3, 2025

审阅者指南 by Sourcery

此拉取请求更新了 README.md 文件,以反映现在支持日本版 MaiMai DX。版本号已从 1.40 更新到 1.45,代号也从 BUDDiES 更新到 BUDDiES PLUS。

MaiMai DX 版本更新状态图

stateDiagram-v2
    BUDDiES_140: MaiMai DX v1.40 (BUDDiES)
    BUDDiES_PLUS_145: MaiMai DX v1.45 (BUDDiES PLUS)
    BUDDiES_140 --> BUDDiES_PLUS_145: 版本更新
    note right of BUDDiES_PLUS_145
        日本版现在与
        国际版匹配
    end note
Loading

文件级别变更

变更 详情 文件
更新 MaiMai DX 的游戏版本和代号。
  • 版本从 1.40 更新到 1.45。
  • 代号从 BUDDiES 更新到 BUDDiES PLUS。
README.md

提示和命令

与 Sourcery 交互

  • 触发新审阅: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub 问题: 通过回复评论要求 Sourcery 创建问题。
  • 生成拉取请求标题: 在拉取请求标题的任何位置写 @sourcery-ai 以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何位置写 @sourcery-ai summary 以随时生成 PR 摘要。您还可以使用此命令指定摘要的插入位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审阅功能,如 Sourcery 生成的拉取请求摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、删除或编辑自定义审阅说明。
  • 调整其他审阅设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This pull request updates the README.md file to reflect that the Japan version of MaiMai DX is now supported. The version number has been updated from 1.40 to 1.45 and the codename has been updated from BUDDiES to BUDDiES PLUS.

State diagram for MaiMai DX version update

stateDiagram-v2
    BUDDiES_140: MaiMai DX v1.40 (BUDDiES)
    BUDDiES_PLUS_145: MaiMai DX v1.45 (BUDDiES PLUS)
    BUDDiES_140 --> BUDDiES_PLUS_145: Version Update
    note right of BUDDiES_PLUS_145
        Japan version now matches
        International version
    end note
Loading

File-Level Changes

Change Details Files
Updated the game version and codename for MaiMai DX.
  • Updated the version from 1.40 to 1.45.
  • Updated the codename from BUDDiES to BUDDiES PLUS.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewiilover - 我已经审查了你的更改 - 以下是一些反馈:

整体评论

  • 'BUDDiES PLUS'(两个空格)和 'BUDDiES PLUS'(一个空格)的间距不一致 - 请标准化为单词之间的单一间距
以下是我在审查期间查看的内容
  • 🟡 一般问题:发现1个问题
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对开源是免费的 - 如果你喜欢我们的评论,请考虑分享它们 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English

Hey @thewiilover - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There's an inconsistent spacing in 'BUDDiES PLUS' (two spaces) vs 'BUDDiES PLUS' (one space) - please standardize to single spacing between words
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

README.md Outdated Show resolved Hide resolved
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@hykilpikonna hykilpikonna merged commit 9090044 into MewoLab:v1-dev Jan 4, 2025
@hykilpikonna
Copy link
Collaborator

Lol thanks

@thewiilover
Copy link
Contributor Author

The ocd kicked immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants