[RF] move userMusicFromList to GameApiController and add GenericUserM… #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
审阅者指南 by Sourcery这个拉取请求通过将 新的 GenericUserMusicRepo 层次结构的类图classDiagram
class IGenericUserMusic {
<<interface>>
+musicId: Int
}
class GenericUserMusicRepo~T~ {
<<interface>>
+findByUserCardExtId(extId: Long): List~T~
+findByUser_Card_ExtIdAndMusicIdIn(userId: Long, musicId: List~Int~): List~T~
}
class Mai2UserMusicDetail {
+override musicId: Int
+level: Int
+playCount: Int
+achievement: Int
}
class UserMusicDetail {
+override musicId: Int
+level: Int
+playCount: Int
+scoreMax: Int
}
class WcUserScore {
+override musicId: Int
+level: Int
+achievement: Int
}
IGenericUserMusic <|.. Mai2UserMusicDetail
IGenericUserMusic <|.. UserMusicDetail
IGenericUserMusic <|.. WcUserScore
GenericUserMusicRepo <|.. Mai2UserMusicDetailRepo
GenericUserMusicRepo <|.. Chu3UserMusicDetailRepo
GenericUserMusicRepo <|.. WcUserBestScoreRepo
note for IGenericUserMusic "新的具有音乐ID的实体接口"
GameApiController 变更的类图classDiagram
class GameApiController~T~ {
+name: String
+us: AquaUserServices
+userDataRepo: GenericUserDataRepo~T~
+playlogRepo: GenericPlaylogRepo~*~
+userMusicRepo: GenericUserMusicRepo~*~
+userMusicFromList(username: String, musicList: List~Int~)
}
class Maimai2 {
+userMusicRepo: Mai2UserMusicDetailRepo
}
class Chusan {
+userMusicRepo: Chu3UserMusicDetailRepo
}
class Wacca {
+userMusicRepo: WcUserBestScoreRepo
}
class Ongeki {
+userMusicRepo: UserMusicDetailRepository
}
GameApiController <|-- Maimai2
GameApiController <|-- Chusan
GameApiController <|-- Wacca
GameApiController <|-- Ongeki
note for GameApiController "添加了 userMusicRepo 并将 userMusicFromList 移至此处"
文件级变更
提示和命令与 Sourcery 交互
自定义您的体验访问您的仪表板以：
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request refactors the user music retrieval logic by moving the Class diagram for the new GenericUserMusicRepo hierarchyclassDiagram
class IGenericUserMusic {
<<interface>>
+musicId: Int
}
class GenericUserMusicRepo~T~ {
<<interface>>
+findByUserCardExtId(extId: Long): List~T~
+findByUser_Card_ExtIdAndMusicIdIn(userId: Long, musicId: List~Int~): List~T~
}
class Mai2UserMusicDetail {
+override musicId: Int
+level: Int
+playCount: Int
+achievement: Int
}
class UserMusicDetail {
+override musicId: Int
+level: Int
+playCount: Int
+scoreMax: Int
}
class WcUserScore {
+override musicId: Int
+level: Int
+achievement: Int
}
IGenericUserMusic <|.. Mai2UserMusicDetail
IGenericUserMusic <|.. UserMusicDetail
IGenericUserMusic <|.. WcUserScore
GenericUserMusicRepo <|.. Mai2UserMusicDetailRepo
GenericUserMusicRepo <|.. Chu3UserMusicDetailRepo
GenericUserMusicRepo <|.. WcUserBestScoreRepo
note for IGenericUserMusic "New interface for entities with music ID"
Class diagram for GameApiController changesclassDiagram
class GameApiController~T~ {
+name: String
+us: AquaUserServices
+userDataRepo: GenericUserDataRepo~T~
+playlogRepo: GenericPlaylogRepo~*~
+userMusicRepo: GenericUserMusicRepo~*~
+userMusicFromList(username: String, musicList: List~Int~)
}
class Maimai2 {
+userMusicRepo: Mai2UserMusicDetailRepo
}
class Chusan {
+userMusicRepo: Chu3UserMusicDetailRepo
}
class Wacca {
+userMusicRepo: WcUserBestScoreRepo
}
class Ongeki {
+userMusicRepo: UserMusicDetailRepository
}
GameApiController <|-- Maimai2
GameApiController <|-- Chusan
GameApiController <|-- Wacca
GameApiController <|-- Ongeki
note for GameApiController "Added userMusicRepo and moved userMusicFromList here"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
嘿 @clansty - 我已经审查了你的更改，看起来非常棒！
以下是我在审查期间关注的内容
- 🟢 一般性问题：一切看起来都很好
- 🟢 安全性：一切看起来都很好
- 🟢 测试：一切看起来都很好
- 🟢 复杂性：一切看起来都很好
- 🟢 文档：一切看起来都很好
帮助我变得更有用！请在每条评论上点击 👍 或 👎，我将使用这些反馈来改进你的评论。
Original comment in English
Hey @clansty - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
hykilpikonna
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…usicRepo
Summary by Sourcery
重构用户音乐检索逻辑，将其从单个游戏控制器移动到
GameApiController，并引入通用的GenericUserMusicRepo接口。新特性：
增强：
GenericUserMusic接口和GenericUserMusicRepo，以处理不同游戏中的用户音乐数据。userMusicFromListAPI 端点移动到GameApiController，提供集中的实现。Original summary in English
Summary by Sourcery
Refactor the user music retrieval logic by moving it from individual game controllers to the
GameApiControllerand introducing a genericGenericUserMusicRepointerface.New Features:
Enhancements:
GenericUserMusicinterface andGenericUserMusicRepoto handle user music data across different games.userMusicFromListAPI endpoint to theGameApiControllerto provide a centralized implementation.