Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: penguin appearance fixes #103

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

raymonable
Copy link
Contributor

@raymonable raymonable commented Jan 6, 2025

sorry for so many PRs, this is hopefully the final one 😭

this just fixes the thing that's on the avatar's forehead (to be honest, i'm not sure what it's called) because i assumed it was only for the initial hat. 😭

Summary by Sourcery

Bug 修复:

  • 修复了企鹅头部配饰在非默认帽子下显示不正确的问题。
Original summary in English

Summary by Sourcery

Bug Fixes:

  • Fixed an issue where the penguin's forehead accessory was not displaying correctly with hats other than the default.

Copy link
Contributor

sourcery-ai bot commented Jan 6, 2025

审阅者指南 by Sourcery

此 PR 修复了一个视觉错误,即企鹅的额头配饰在某些帽子下无法正确显示。修复涉及移除阻止额头配饰显示的条件逻辑(除非装备特定帽子)。此外,额头配饰的位置也略有调整。

企鹅头像渲染过程的序列图

sequenceDiagram
    participant C as ChuniPenguin Component
    participant D as DDSReader
    participant R as Renderer
    C->>D: Request base penguin image
    D-->>C: Return base image
    C->>D: Request head accessory
    D-->>C: Return head image
    Note over C: New: Always request forehead
    C->>D: Request forehead accessory
    D-->>C: Return forehead image
    C->>D: Request face accessory
    D-->>C: Return face image
    C->>R: Render all components
    Note over R: Adjusted forehead position
Loading

企鹅头像外观逻辑的状态图

stateDiagram-v2
    [*] --> PenguinAvatar
    state PenguinAvatar {
        [*] --> DisplayBase
        DisplayBase --> AddHead
        AddHead --> AddForehead
        state AddForehead {
            state "Old Logic" as OldLogic
            state "New Logic" as NewLogic
            OldLogic: Show forehead only with hat 1200001
            NewLogic: Show forehead with all hats
        }
        AddForehead --> AddFace
        AddFace --> [*]
    }
Loading

文件级变更

变更 详情 文件
始终显示额头配饰。
  • 移除了仅在 chuniHead 等于 1200001 时显示额头配饰的条件块。
  • 添加了无条件显示额头配饰的新块。
  • 将额头配饰的图像源从 surfboard:CHU_UI_Common_Avatar_body_00.dds 在坐标 5, 160, 100, 150 更新到坐标 105, 153, 56, 58
AquaNet/src/components/settings/userbox/ChuniPenguin.svelte
调整额头配饰的位置。
  • .chuni-penguin-head-2 类的 top 样式从 12.5% 修改为 13.5%
AquaNet/src/components/settings/userbox/ChuniPenguin.svelte

提示和命令

与 Sourcery 交互

  • 触发新审阅: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub 问题: 通过回复审阅评论,要求 Sourcery 创建问题。
  • 生成拉取请求标题: 在拉取请求标题的任何位置写 @sourcery-ai 以随时生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何位置写 @sourcery-ai summary 以随时生成 PR 摘要。您还可以使用此命令指定摘要的插入位置。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审阅功能,如 Sourcery 生成的拉取请求摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、删除或编辑自定义审阅说明。
  • 调整其他审阅设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This PR fixes a visual bug where the penguin's forehead accessory was not displaying correctly with certain hats. The fix involves removing conditional logic that was preventing the forehead accessory from appearing unless a specific hat was equipped. Additionally, the positioning of the forehead accessory has been slightly adjusted.

Sequence diagram for penguin avatar rendering process

sequenceDiagram
    participant C as ChuniPenguin Component
    participant D as DDSReader
    participant R as Renderer
    C->>D: Request base penguin image
    D-->>C: Return base image
    C->>D: Request head accessory
    D-->>C: Return head image
    Note over C: New: Always request forehead
    C->>D: Request forehead accessory
    D-->>C: Return forehead image
    C->>D: Request face accessory
    D-->>C: Return face image
    C->>R: Render all components
    Note over R: Adjusted forehead position
Loading

State diagram for penguin avatar appearance logic

stateDiagram-v2
    [*] --> PenguinAvatar
    state PenguinAvatar {
        [*] --> DisplayBase
        DisplayBase --> AddHead
        AddHead --> AddForehead
        state AddForehead {
            state "Old Logic" as OldLogic
            state "New Logic" as NewLogic
            OldLogic: Show forehead only with hat 1200001
            NewLogic: Show forehead with all hats
        }
        AddForehead --> AddFace
        AddFace --> [*]
    }
Loading

File-Level Changes

Change Details Files
Always display the forehead accessory.
  • Removed the conditional block that only displayed the forehead accessory when chuniHead was equal to 1200001.
  • Added a new block to unconditionally display the forehead accessory.
  • Updated the image source for the forehead accessory from surfboard:CHU_UI_Common_Avatar_body_00.dds at coordinates 5, 160, 100, 150 to coordinates 105, 153, 56, 58.
AquaNet/src/components/settings/userbox/ChuniPenguin.svelte
Adjust the positioning of the forehead accessory.
  • Modified the top style of the .chuni-penguin-head-2 class from 12.5% to 13.5%.
AquaNet/src/components/settings/userbox/ChuniPenguin.svelte

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raymonable - 我已经审查了你的更改,看起来非常棒!

以下是我在审查期间查看的内容
  • 🟢 一般性问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对开源项目是免费的 - 如果你喜欢我们的评论,请考虑分享 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English

Hey @raymonable - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hykilpikonna hykilpikonna merged commit ef43513 into MewoLab:v1-dev Jan 6, 2025
@hykilpikonna
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants