-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[+] Allow disable music rank for own machine #110
Conversation
Here's the translation of the review guide to Chinese: 审阅者指南 by Sourcery此拉取请求引入了一个新功能,允许用户在自己的机器上禁用音乐排名显示。这是通过添加新的游戏选项并修改游戏排名处理程序以遵守此选项来实现的。 带有新禁用选项的音乐排名检索序列图sequenceDiagram
participant Game as Game Client
participant Handler as GetGameRankingHandler
participant Token as TokenChecker
participant Options as GameOptions
Game->>Handler: Request ranking (type=1)
Handler->>Token: getCurrentSession()
Token->>Options: Get user.gameOptions
Options-->>Handler: Return enableMusicRank setting
alt enableMusicRank is true
Handler-->>Game: Return music ranking list
else enableMusicRank is false
Handler-->>Game: Return empty list
end
数据库变更的实体关系图erDiagram
AQUA_GAME_OPTIONS {
bit enable_music_rank
}
note for AQUA_GAME_OPTIONS "添加 enable_music_rank 列,默认值为 1"
显示更新的游戏选项结构的类图classDiagram
class AquaGameOptions {
+String chusanMatchingReflector
+Boolean enableMusicRank
}
class GetGameRankingHandler {
-List musicRankingCache
+handle(Map request): Map
}
note for AquaGameOptions "添加 enableMusicRank 字段"
note for GetGameRankingHandler "修改为检查 enableMusicRank 设置"
文件级变更
提示和命令与 Sourcery 交互
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request introduces a new feature that allows users to disable the music rank display on their own machines. This is achieved by adding a new game option and modifying the game ranking handler to respect this option. Sequence diagram for music ranking retrieval with new disable optionsequenceDiagram
participant Game as Game Client
participant Handler as GetGameRankingHandler
participant Token as TokenChecker
participant Options as GameOptions
Game->>Handler: Request ranking (type=1)
Handler->>Token: getCurrentSession()
Token->>Options: Get user.gameOptions
Options-->>Handler: Return enableMusicRank setting
alt enableMusicRank is true
Handler-->>Game: Return music ranking list
else enableMusicRank is false
Handler-->>Game: Return empty list
end
Entity relationship diagram for database changeserDiagram
AQUA_GAME_OPTIONS {
bit enable_music_rank
}
note for AQUA_GAME_OPTIONS "Added enable_music_rank column with default value 1"
Class diagram showing updated game options structureclassDiagram
class AquaGameOptions {
+String chusanMatchingReflector
+Boolean enableMusicRank
}
class GetGameRankingHandler {
-List musicRankingCache
+handle(Map request): Map
}
note for AquaGameOptions "Added enableMusicRank field"
note for GetGameRankingHandler "Modified to check enableMusicRank setting"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @clansty - 我已经审查了你的更改,看起来非常棒!
以下是我在审查期间关注的内容
- 🟢 一般性问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English
Hey @clansty - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
支持通过设置更改是否要给自己的机器显示推荐乐曲排行榜
因为我本地的数据貌似不够生成排行榜所以没有完全测试
Summary by Sourcery
允许禁用用户自己机器上的推荐音乐排名。
新功能:
测试:
Original summary in English
Summary by Sourcery
Allow disabling the recommended music rank for a user's own machine.
New Features:
Tests: