aquabox improvements #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
审阅者指南 by Sourcery这个拉取请求引入了一个新功能，允许用户在其Chunithm用户页面上显示其铭牌和头像。它还包括修复头像显示以更准确地呈现游戏内外观、修复服务器URL、更改一些字符串并更新翻译。 AquaBox组件的类图classDiagram
class ChuniPenguinComponent {
+chuniWear: number
+chuniHead: number
+chuniBack: number
+chuniFront: number
+chuniFace: number
+chuniItem: number
+chuniSkin: number
+classPassthrough: string
}
class ChuniUserplateComponent {
+chuniLevel: string
+chuniName: string
+chuniRating: number
+chuniNameplate: number
+chuniCharacter: number
+chuniTrophyName: string
+chuniIsUserbox: boolean
}
class DDSCache {
-db: IDBDatabase
-urlCache: array
+userboxURL: string
+getFromDatabase(path: string): Promise
}
note for DDSCache "添加URL模式支持"
note for ChuniPenguinComponent "更新手臂定位"
note for ChuniUserplateComponent "添加个人资料显示支持"
文件级别变更
提示和命令与Sourcery交互
自定义您的体验访问您的仪表板以：
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request introduces a new feature that allows users to display their nameplate and avatar on their Chunithm user pages. It also includes a fix for the avatar display to be more accurate to the in-game appearance, fixes server URLs, changes some strings, and updates translations. Class diagram for AquaBox componentsclassDiagram
class ChuniPenguinComponent {
+chuniWear: number
+chuniHead: number
+chuniBack: number
+chuniFront: number
+chuniFace: number
+chuniItem: number
+chuniSkin: number
+classPassthrough: string
}
class ChuniUserplateComponent {
+chuniLevel: string
+chuniName: string
+chuniRating: number
+chuniNameplate: number
+chuniCharacter: number
+chuniTrophyName: string
+chuniIsUserbox: boolean
}
class DDSCache {
-db: IDBDatabase
-urlCache: array
+userboxURL: string
+getFromDatabase(path: string): Promise
}
note for DDSCache "Added URL mode support"
note for ChuniPenguinComponent "Updated arm positioning"
note for ChuniUserplateComponent "Added profile display support"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
嘿 @raymonable - 我已经审查了你的更改，看起来非常棒！
以下是我在审查期间关注的内容
- 🟢 一般性问题：一切看起来都很好
- 🟢 安全性：一切看起来都很好
- 🟢 测试：一切看起来都很好
- 🟢 复杂性：一切看起来都很好
- 🟢 文档：一切看起来都很好
帮助我变得更有用！请在每条评论上点击 👍 或 👎，我将使用这些反馈来改进你的评论。
Original comment in English
Hey @raymonable - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
working on primary aqua server, just awaiting review |
(helpful for when it's longer than the box has)
raymonable
changed the title
|
converted to draft because we need to properly re-implement the server url stuff (and i will write proper documentation and scripts for extracting the files) |
|
sorry some of the commits are a little messy-- i'm still not very great with git but hopefully the other 2 merge conflicts are easy to solve |
There was a problem hiding this comment.
嘿 @raymonable - 我已经审查了你的更改，它们看起来很棒！
这是我在审查期间查看的内容
- 🟡 一般问题：发现2个问题
- 🟢 安全性：一切看起来都很好
- 🟢 测试：一切看起来都很好
- 🟢 复杂性：一切看起来都很好
- 🟢 文档：一切看起来都很好
帮助我变得更有用！请在每条评论上点击👍或👎，我将使用反馈来改进你的审查。
Original comment in English
Hey @raymonable - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
docs/aquabox-url-mode.md
Outdated
|
|
||
| 1. Extract your Chunithm Luminous game files. | ||
|
|
||
| It is recommend you have the latest version of the game and all of the options your users may use. |
There was a problem hiding this comment.
issue (typo): 拼写错误：“recommend”应为“recommended”。
Suggested change
| It is recommend you have the latest version of the game and all of the options your users may use. | |
| It is recommended you have the latest version of the game and all of the options your users may use. |
Original comment in English
issue (typo): Typo: "recommend" should be "recommended".
Suggested change
| It is recommend you have the latest version of the game and all of the options your users may use. | |
| It is recommended you have the latest version of the game and all of the options your users may use. |
docs/aquabox-url-mode.md
Outdated
|
|
||
| It is recommend you have the latest version of the game and all of the options your users may use. | ||
|
|
||
| The script to generate the proper paths can be found in [/tools/chusan-extractor.js](/tools/chusan-extractor.js). Node.js or Bun is required.<br> |
There was a problem hiding this comment.
issue (bug_risk): 路径错误：脚本位于tools/extract-chusan.js，而不是/tools/chusan-extractor.js。
Original comment in English
issue (bug_risk): Incorrect path: The script is at tools/extract-chusan.js, not /tools/chusan-extractor.js.
There was a problem hiding this comment.
嘿 @raymonable - 我已经审查了你的更改 - 这里有一些反馈：
总体评论：
- 考虑为资产加载功能添加更全面的URL验证和速率限制，以防止恶意URL带来的潜在安全问题。
这是我在审查期间查看的内容
- 🟡 一般问题：发现1个问题
- 🟢 安全性：一切看起来都很好
- 🟢 测试：一切看起来都很好
- 🟢 复杂性：一切看起来都很好
- 🟢 文档：一切看起来都很好
帮助我变得更有用！请点击每条评论上的👍或👎，我将使用反馈来改进你的评论。
Original comment in English
Hey @raymonable - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding more thorough URL validation and rate limiting for the asset loading functionality to prevent potential security issues with malicious URLs.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| > :warning: Assets are already not hosted on AquaDX for legal reasons.<br> | ||
| > Hosting SEGA's assets may put you at higher risk of DMCA. | ||
|
|
||
| 1. Extract your Chunithm Luminous game files. |
There was a problem hiding this comment.
问题（错字）： 错字：“Luminous” 应为 “SUN”
将“Chunithm Luminous 游戏文件”更改为“Chunithm SUN 游戏文件”。Luminous 指的是机柜，而 SUN 是游戏本身。
Suggested change
| 1. Extract your Chunithm Luminous game files. | |
| 1. 提取你的 Chunithm SUN 游戏文件。 |
Original comment in English
issue (typo): Typo: "Luminous" should be "SUN"
Change "Chunithm Luminous game files" to "Chunithm SUN game files". Luminous refers to the cabinet, while SUN is the game itself.
Suggested change
| 1. Extract your Chunithm Luminous game files. | |
| 1. Extract your Chunithm SUN game files. |
|
it's actually ready now |
|
It’s showing merge conflicts for me lol |
yeah it's because git is stupid, they're really easy to fix (i just can't be bothered to do so) |
😔 |
hykilpikonna
approved these changes
Jan 5, 2025
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new:
but:
Summary by Sourcery
新功能：
Original summary in English
Summary by Sourcery
New Features:
Summary by Sourcery
为用户框资源添加自定义基础 URL 支持，允许用户指定获取资源的 URL。更新匹配服务器设置界面，使用户能够从匹配服务器列表中选择或指定自定义 URL。
新功能：
测试：
Original summary in English
Summary by Sourcery
Add support for custom base URLs for userbox assets, allowing users to specify a URL to fetch assets from. Update the matching server settings UI to allow users to select from a list of matching servers or specify a custom URL.
New Features:
Tests:
新功能：
测试：
Original summary in English
Summary by Sourcery
为用户框资源添加自定义基础 URL 支持，允许用户指定获取资源的 URL。更新匹配服务器设置界面，使用户能够从匹配服务器列表中选择或指定自定义 URL。
新功能：
测试：
Original summary in English
Summary by Sourcery
Add support for custom base URLs for userbox assets, allowing users to specify a URL to fetch assets from. Update the matching server settings UI to allow users to select from a list of matching servers or specify a custom URL.
New Features:
Tests: