Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+] Unlock collections (without altering user data), courses and characters #15

Merged
merged 15 commits into from
Jan 30, 2025

Conversation

Menci
Copy link
Contributor

@Menci Menci commented Jan 25, 2025

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在设置菜单中添加了解锁所有收藏、课程和角色的选项。此更改仅影响显示,不会授予任何新项目或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)的选项。这仅影响显示,不会授予任何新物品或进度。
  • 在设置菜单中添加了解锁所有课程的选项。这仅影响显示,不会授予任何新物品或进度。
  • 在设置菜单中添加了解锁所有角色的选项。这仅影响显示,不会授予任何新物品或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在设置菜单中添加了解锁所有收藏、课程和角色的选项。此更改仅影响显示,不会授予任何新项目或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在设置菜单中添加了解锁所有收藏、课程和角色的选项。这仅影响设置中的显示,不会授予任何新物品或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在设置菜单中添加了解锁所有收藏、课程和角色的选项。此更改仅影响显示,不会授予任何新项目或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)的选项。这仅影响显示,不会授予任何新物品或进度。
  • 在设置菜单中添加了解锁所有课程的选项。这仅影响显示,不会授予任何新物品或进度。
  • 在设置菜单中添加了解锁所有角色的选项。这仅影响显示,不会授予任何新物品或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在设置菜单中添加了解锁所有收藏、课程和角色的选项。此更改仅影响显示,不会授予任何新项目或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在收藏设置菜单中添加了解锁所有标题、图标、名牌、框架和伙伴的选项。这仅影响设置中的显示,不会为用户授予任何新物品或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在设置菜单中添加了解锁所有收藏、课程和角色的选项。此更改仅影响显示,不会授予任何新项目或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)的选项。这仅影响显示,不会授予任何新物品或进度。
  • 在设置菜单中添加了解锁所有课程的选项。这仅影响显示,不会授予任何新物品或进度。
  • 在设置菜单中添加了解锁所有角色的选项。这仅影响显示,不会授予任何新物品或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在设置菜单中添加了解锁所有收藏、课程和角色的选项。此更改仅影响显示,不会授予任何新项目或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在设置菜单中添加了解锁所有收藏、课程和角色的选项。这仅影响设置中的显示,不会授予任何新物品或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在设置菜单中添加了解锁所有收藏、课程和角色的选项。此更改仅影响显示,不会授予任何新项目或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)的选项。这仅影响显示,不会授予任何新物品或进度。
  • 在设置菜单中添加了解锁所有课程的选项。这仅影响显示,不会授予任何新物品或进度。
  • 在设置菜单中添加了解锁所有角色的选项。这仅影响显示,不会授予任何新物品或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.
- 在设置菜单中添加了解锁所有收藏、课程和角色的选项。此更改仅影响显示,不会授予任何新项目或进度。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

新功能:

  • 在设置菜单中添加了解锁所有收藏品(标题、图标、名牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

在设置菜单中添加解锁所有收藏品(标题、图标、铭牌、框架和伙伴)、课程和角色的选项。这仅影响显示,不会授予任何新物品或进度。

新功能:

  • 在设置菜单中添加了解锁所有收藏品、课程和角色的选项。此更改仅影响显示,不会授予任何新物品或进度。

测试:

  • 为新的解锁选项添加了测试。
Original summary in English

Summary by Sourcery

Add options to unlock all collectibles (titles, icons, nameplates, frames, and partners), courses, and characters in the settings menu. This only affects the display and does not grant any new items or progress.

New Features:

  • Added options in the settings menu to unlock all collectibles, courses, and characters. This change only affects the display and does not grant any new items or progress.

Tests:

  • Added tests for the new unlock options.

Copy link

sourcery-ai bot commented Jan 25, 2025

审阅者指南 by Sourcery

这个拉取请求引入了几个新功能,用于解锁通常被锁定的游戏内容,包括地图、歌曲、门票、课程、收藏品和角色。这些解锁是通过修补各种游戏方法来绕过原始解锁条件实现的。这些更改主要影响解锁内容的显示,除了角色等级外,不会为用户账户授予任何新物品或进度。

解锁系统的类图

classDiagram
    class Unlock {
        -bool maps
        -bool songs
        -bool tickets
        -bool courses
        -bool utage
        -bool titles
        -bool icons
        -bool plates
        -bool frames
        -bool partners
        -bool characters
        +OnBeforeEnableCheck()
    }

    class MapHook {
        +get_OpenEventId(ref StringID)
        +get_IsLock(ref bool)
        +PreIsLock(ref bool)
    }

    class SongHook {
        +IsAllOpen(ref bool)
        +PreToNextProcess()
        +FinToNextProcess()
    }

    class CollectionHook {
        +GetAllUnlockedItemList()
        +Prefix()
        +Finalizer()
    }

    class CharacterHook {
        -State AllUnlockedList
        -State OriginalList
        -State ExportList
        +PreInitialize()
        +FinInitialize()
        +ApplyState()
    }

    Unlock *-- MapHook
    Unlock *-- SongHook
    Unlock *-- CollectionHook
    Unlock *-- CharacterHook
Loading

角色解锁系统的状态图

stateDiagram-v2
    [*] --> AllUnlockedList
    AllUnlockedList --> OriginalList: 初始化/恢复角色数据
    OriginalList --> AllUnlockedList: 完成操作
    AllUnlockedList --> ExportList: 导出到服务器
    ExportList --> AllUnlockedList: 完成导出

    note right of AllUnlockedList: 显示所有角色
    note right of OriginalList: 显示拥有的角色
    note right of ExportList: 显示拥有的 + 升级的角色
Loading

文件级别变更

变更 详情 文件
添加解锁所有地图的选项,包括当前版本中未包含的地图。
  • 修补 MapData.get_OpenEventId 以返回默认解锁事件 ID。
  • 修补 UserMapData.get_IsLock 以始终返回 false。
  • 修补 MapMaster.IsLock 以始终返回 false。
AquaMai.Mods/GameSystem/Unlock.cs
添加解锁所有歌曲并跳过 Master/ReMaster 解锁屏幕的选项。
  • 修补 MAI2System.Config.IsAllOpen 以始终返回 true。
  • 修补 ResultProcess.ToNextProcess 以跳过解锁过程,但仍正常保存音乐 Master/ReMaster 解锁状态。
AquaMai.Mods/GameSystem/Unlock.cs
添加解锁所有门票的选项。
  • 修补 TicketData.get_ticketEvent 以返回默认解锁事件 ID。
  • 修补 TicketData.get_maxCount 以返回 0。
AquaMai.Mods/GameSystem/Unlock.cs
添加解锁所有课程模式课程的选项。
  • 修补 CourseData.get_eventId 以返回默认解锁事件 ID。
  • 修补 CourseData.get_isLock 以始终返回 false。
AquaMai.Mods/GameSystem/Unlock.cs
添加在不满足分数要求的情况下解锁 Utage 模式的选项。
  • 修补 GameManager.CanUnlockUtageTotalJudgement 以始终返回解锁。
AquaMai.Mods/GameSystem/Unlock.cs
添加解锁所有收藏品(标题、图标、牌匾、框架和伙伴)的选项。
  • 修补 CollectionProcess.CreateXXXData 方法以将相应的 UserData 属性设置为所有解锁列表,并在方法调用后恢复。
AquaMai.Mods/GameSystem/Unlock.cs
添加解锁所有角色的选项。
  • 修补 UserData.InitializePlInformationProcess.RestoreCharadata 以使用所有解锁角色初始化用户的角色列表。
  • 修补 UserData.AddCollections 以允许游戏将角色添加到原始列表。
  • 修补 VOExtensions.ExportUserAll 以导出原始角色列表和升级的角色。
AquaMai.Mods/GameSystem/Unlock.cs
修复由缺少角色地图颜色数据导致的崩溃。
  • 修补 CharacterSelectProces.GetMapColorData 以在颜色缺失时回退到第一个地图的颜色。
  • 修补 CommonMonitor.SetCharacterSlot 以在角色插槽数据缺失时跳过加载角色。
  • 修补 MapMaster.Initialize 以初始化缺失的地图颜色。
  • 修补 CommonMonitor.CreateCharacterSlotData 以初始化缺失的角色插槽数据。
  • 修补 DataManager.GetMapColorData 以在颜色缺失时回退到第一个颜色。
AquaMai.Mods/Fix/Stability/FixMissingCharaCrash.cs
清理用户数据以防止由无效物品 ID 导致的崩溃。
  • 清理用户数据和用户扩展数据中的物品 ID 字段,以确保它们有效。
  • 清理用户扩展数据中的枚举字段,以确保它们已定义。
AquaMai.Mods/Fix/Stability/SanitizeUserData.cs
添加新的生命周期方法 OnBeforeEnableCheck 以初始化在 EnableIf 属性中使用的字段。
  • 添加新的生命周期方法 OnBeforeEnableCheck 以初始化在 EnableIf 属性中使用的字段。
  • 在收集补丁之前调用新的生命周期方法。
AquaMai.Core/Startup.cs
System.Runtime.CompilerServices.IsExternalInit 添加兼容层。
  • System.Runtime.CompilerServices.IsExternalInit 添加兼容层以支持 C# 9.0 语法。
AquaMai.Mods/Polyfills.cs

提示和命令

与 Sourcery 交互

  • 触发新的审阅: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub 问题: 通过回复审阅评论要求 Sourcery 创建问题。您也可以用 @sourcery-ai issue 回复审阅评论来创建问题。
  • 生成拉取请求标题: 在拉取请求标题的任何位置写 @sourcery-ai 以随时生成标题。您也可以在拉取请求中评论 @sourcery-ai title 以随时(重新)生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任何位置写 @sourcery-ai summary 以在您想要的确切位置生成 PR 摘要。您也可以在拉取请求中评论 @sourcery-ai summary 以随时(重新)生成摘要。
  • 生成审阅者指南: 在拉取请求中评论 @sourcery-ai guide 以随时(重新)生成审阅者指南。
  • 解决所有 Sourcery 评论: 在拉取请求中评论 @sourcery-ai resolve 以解决所有 Sourcery 评论。如果您已经处理了所有评论,并且不想再看到它们,这很有用。
  • 取消所有 Sourcery 审阅: 在拉取请求中评论 @sourcery-ai dismiss 以取消所有现有的 Sourcery 审阅。特别是在您想重新开始审阅时很有用 - 别忘了评论 @sourcery-ai review 以触发新的审阅!
  • 为问题生成行动计划: 在问题中评论 @sourcery-ai plan 以为其生成行动计划。

自定义您的体验

访问您的仪表板以:

  • 启用或禁用审阅功能,如 Sourcery 生成的拉取请求摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、删除或编辑自定义审阅说明。
  • 调整其他审阅设置。

获取帮助

Original review guide in English

Reviewer's Guide by Sourcery

This pull request introduces several new features to unlock normally locked game content, including maps, songs, tickets, courses, collectibles, and characters. These unlocks are implemented by patching various game methods to bypass the original unlock conditions. The changes primarily affect the display of unlocked content and do not grant any new items or progress to the user's account, except for character levels.

Class diagram for the unlock system

classDiagram
    class Unlock {
        -bool maps
        -bool songs
        -bool tickets
        -bool courses
        -bool utage
        -bool titles
        -bool icons
        -bool plates
        -bool frames
        -bool partners
        -bool characters
        +OnBeforeEnableCheck()
    }

    class MapHook {
        +get_OpenEventId(ref StringID)
        +get_IsLock(ref bool)
        +PreIsLock(ref bool)
    }

    class SongHook {
        +IsAllOpen(ref bool)
        +PreToNextProcess()
        +FinToNextProcess()
    }

    class CollectionHook {
        +GetAllUnlockedItemList()
        +Prefix()
        +Finalizer()
    }

    class CharacterHook {
        -State AllUnlockedList
        -State OriginalList
        -State ExportList
        +PreInitialize()
        +FinInitialize()
        +ApplyState()
    }

    Unlock *-- MapHook
    Unlock *-- SongHook
    Unlock *-- CollectionHook
    Unlock *-- CharacterHook
Loading

State diagram for character unlock system

stateDiagram-v2
    [*] --> AllUnlockedList
    AllUnlockedList --> OriginalList: Initialize/RestoreCharadata
    OriginalList --> AllUnlockedList: Complete operation
    AllUnlockedList --> ExportList: Export to server
    ExportList --> AllUnlockedList: Complete export

    note right of AllUnlockedList: Shows all characters
    note right of OriginalList: Shows owned characters
    note right of ExportList: Shows owned + leveled chars
Loading

File-Level Changes

Change Details Files
Added options to unlock all maps, including those not in the current version.
  • Patched MapData.get_OpenEventId to return a default unlock event ID.
  • Patched UserMapData.get_IsLock to always return false.
  • Patched MapMaster.IsLock to always return false.
AquaMai.Mods/GameSystem/Unlock.cs
Added options to unlock all songs and skip the Master/ReMaster unlock screen.
  • Patched MAI2System.Config.IsAllOpen to always return true.
  • Patched ResultProcess.ToNextProcess to skip the unlock process but still save the music Master/ReMaster unlock status normally.
AquaMai.Mods/GameSystem/Unlock.cs
Added options to unlock all tickets.
  • Patched TicketData.get_ticketEvent to return a default unlock event ID.
  • Patched TicketData.get_maxCount to return 0.
AquaMai.Mods/GameSystem/Unlock.cs
Added options to unlock all course-mode courses.
  • Patched CourseData.get_eventId to return a default unlock event ID.
  • Patched CourseData.get_isLock to always return false.
AquaMai.Mods/GameSystem/Unlock.cs
Added options to unlock the Utage mode without meeting the score requirement.
  • Patched GameManager.CanUnlockUtageTotalJudgement to always return unlocked.
AquaMai.Mods/GameSystem/Unlock.cs
Added options to unlock all collectibles (titles, icons, plates, frames, and partners).
  • Patched CollectionProcess.CreateXXXData methods to set the corresponding UserData property to the all unlocked list and restore it after the method call.
AquaMai.Mods/GameSystem/Unlock.cs
Added options to unlock all characters.
  • Patched UserData.Initialize and PlInformationProcess.RestoreCharadata to initialize the user's character list with all unlocked characters.
  • Patched UserData.AddCollections to allow the game to add characters to the original list.
  • Patched VOExtensions.ExportUserAll to export the original list of characters and leveled-up characters.
AquaMai.Mods/GameSystem/Unlock.cs
Fixed a crash caused by missing character map color data.
  • Patched CharacterSelectProces.GetMapColorData to fall back to the first map's color if the color is missing.
  • Patched CommonMonitor.SetCharacterSlot to skip loading characters if their slot data is missing.
  • Patched MapMaster.Initialize to initialize missing map colors.
  • Patched CommonMonitor.CreateCharacterSlotData to initialize missing character slot data.
  • Patched DataManager.GetMapColorData to fall back to the first color if the color is missing.
AquaMai.Mods/Fix/Stability/FixMissingCharaCrash.cs
Sanitized user data to prevent crashes caused by invalid item IDs.
  • Sanitized item ID fields in user data and user extend data to ensure they are valid.
  • Sanitized enum fields in user extend data to ensure they are defined.
AquaMai.Mods/Fix/Stability/SanitizeUserData.cs
Added a new lifecycle method OnBeforeEnableCheck to initialize fields used in EnableIf attributes.
  • Added a new lifecycle method OnBeforeEnableCheck to initialize fields used in EnableIf attributes.
  • Invoked the new lifecycle method before collecting patches.
AquaMai.Core/Startup.cs
Added a polyfill for System.Runtime.CompilerServices.IsExternalInit.
  • Added a polyfill for System.Runtime.CompilerServices.IsExternalInit to support C# 9.0 syntax.
AquaMai.Mods/Polyfills.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Menci - 我已经审查了你的更改,看起来非常棒!

以下是我在审查期间关注的内容
  • 🟢 一般性问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟢 复杂性:一切看起来都很好
  • 🟢 文档:一切看起来都很好

Sourcery 对开源项目是免费的 - 如果你喜欢我们的评论,请考虑分享 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English

Hey @Menci - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Menci Menci changed the title [+] Unlock collections (without altering user data) WIP: [+] Unlock collections (without altering user data), courses and characters Jan 25, 2025
@Menci
Copy link
Contributor Author

Menci commented Jan 25, 2025

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Menci - 我已经审查了你的更改 - 以下是一些反馈:

整体评论

  • 考虑在类初始化时缓存 PropertyInfo 和 MethodInfo 对象,而不是在 ModifyUserData 中重复查找,以提高性能
  • 请在合并此 PR 之前澄清哪些方面仍在进行中
以下是我在审查期间查看的内容
  • 🟡 一般性问题:发现 1 个问题
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟡 复杂性:发现 1 个问题
  • 🟢 文档:一切看起来都很好

Sourcery 对开源是免费的 - 如果你喜欢我们的评论,请考虑分享 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English

Hey @Menci - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider caching PropertyInfo and MethodInfo objects at class initialization time rather than looking them up repeatedly in ModifyUserData to improve performance
  • Please clarify what aspects are still WIP before this PR is merged
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

AquaMai.Mods/GameSystem/Unlock.cs Show resolved Hide resolved
AquaMai.Mods/GameSystem/Unlock.cs Show resolved Hide resolved
@Menci Menci changed the title WIP: [+] Unlock collections (without altering user data), courses and characters [+] Unlock collections (without altering user data), courses and characters Jan 26, 2025
@Menci
Copy link
Contributor Author

Menci commented Jan 26, 2025

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Menci - 我已经审查了你的更改,看起来非常棒!

以下是我在审查期间关注的内容
  • 🟡 一般性问题:发现1个问题
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟡 复杂性:发现1个问题
  • 🟢 文档:一切看起来都很好

Sourcery 对开源项目是免费的 - 如果你喜欢我们的评论,请考虑分享 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English

Hey @Menci - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

AquaMai.Mods/GameSystem/Unlock.cs Show resolved Hide resolved
@Menci
Copy link
Contributor Author

Menci commented Jan 26, 2025

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Menci - 我已经审查了你的更改,发现了一些需要解决的问题。

阻塞问题

  • 发现硬编码的秘密 (链接)

总体评论

  • 考虑重构集合钩子,以减少不同集合类型(标题、图标、牌照等)之间的代码重复。目前的实现重复了类似的模式,可以进行整合。
这是我在审查期间查看的内容
  • 🟡 一般问题:发现1个问题
  • 🔴 安全性:1个阻塞问题
  • 🟢 测试:一切看起来都很好
  • 🟡 复杂性:发现1个问题
  • 🟢 文档:一切看起来都很好

Sourcery对开源项目免费 - 如果你喜欢我们的评论,请考虑分享它们 ✨
帮助我变得更有用!请在每条评论上点击👍或👎,我将使用反馈来改进你的评论。
Original comment in English

Hey @Menci - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Hardcoded secret found (link)

Overall Comments:

  • Consider refactoring the collection hooks to reduce code duplication across the different collection types (titles, icons, plates etc). The current implementation repeats similar patterns that could potentially be consolidated.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🔴 Security: 1 blocking issue
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

AquaMai.Mods/GameSystem/Unlock.cs Outdated Show resolved Hide resolved
AquaMai.Mods/GameSystem/Unlock.cs Show resolved Hide resolved
AquaMai.Mods/GameSystem/Unlock.cs Show resolved Hide resolved
@Menci Menci changed the title [+] Unlock collections (without altering user data), courses and characters WIP: [+] Unlock collections (without altering user data), courses and characters Jan 26, 2025
@Menci
Copy link
Contributor Author

Menci commented Jan 27, 2025

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Menci - 我已经审查了你的更改 - 以下是一些反馈:

整体评论

  • 考虑移除 WIP 标签,因为实现看起来已完成并经过充分测试
以下是我在审查期间查看的内容
  • 🟢 一般问题:一切看起来都很好
  • 🟢 安全性:一切看起来都很好
  • 🟢 测试:一切看起来都很好
  • 🟡 复杂性:发现 1 个问题
  • 🟢 文档:一切看起来都很好

Sourcery 对开源项目是免费的 - 如果你喜欢我们的评论,请考虑分享它们 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English

Hey @Menci - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing the WIP tag as the implementation appears complete and well-tested
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

AquaMai.Mods/GameSystem/Unlock.cs Show resolved Hide resolved
@Menci Menci changed the title WIP: [+] Unlock collections (without altering user data), courses and characters [+] Unlock collections (without altering user data), courses and characters Jan 27, 2025
@Menci
Copy link
Contributor Author

Menci commented Jan 27, 2025

@sourcery-ai summary 可否将每一种解锁的状态图都写出来,不止角色解锁,也包括乐曲、功能票、收藏品、段位模式、地图。

@Menci
Copy link
Contributor Author

Menci commented Jan 27, 2025

@sourcery-ai guide 可否将每一种解锁的状态图都写出来,不止角色解锁,也包括乐曲、功能票、收藏品、段位模式、地图。

en: "Unlock all titles.",
zh: "解锁所有称号"
)]
private static readonly bool titles = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得这些新增的都默认改成 false 吧,有很多人是不想要收藏品全解的
多个人共享的机台上面应该服务端全解还会是主流,因为是否要全解这个还是挺看人的

@clansty
Copy link
Contributor

clansty commented Jan 29, 2025

段位那个也默认禁用了吧

Co-authored-by: 凌莞~(=^▽^=) <[email protected]>
@clansty clansty merged commit fff2c19 into main Jan 30, 2025
2 checks passed
@clansty clansty deleted the unlock-collections branch January 30, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants