Fixed Windows build failure #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhaavram01
commented
Sep 8, 2025
| @@ -113,14 +113,6 @@ | |||
| #define STOP 0xFF | |||
| #define SET_XMODE_NONE 0x55 | |||
|
|
|||
| typedef unsigned long DWORD_PTR, *PDWORD_PTR; | |||
There was a problem hiding this comment.
Already moved to ini.h. Removed to fix re-declaration warning
|
Please confirm the OS you tested the wizard and what commands are tested |
Tested in Windows 11 x64 with Windows Kernel Management Driver from https://bitbucket.microchip.com/projects/UNG_STAMFORD/repos/sw-releases/browse/mgmt_ep_windrv/mchp_signed/x64 |
Sure THanks |
pvengat
approved these changes
Sep 10, 2025
| @@ -113,14 +113,6 @@ | |||
| #define STOP 0xFF | |||
| #define SET_XMODE_NONE 0x55 | |||
|
|
|||
| typedef unsigned long DWORD_PTR, *PDWORD_PTR; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira : https://jira.microchip.com/browse/STMFD-3470