Skip to content

Conversation

antnorwe
Copy link
Contributor

  • Added support for the latest behaviour of Get-AzAccessToken, which now returns the token as a securestring, to the Disassociate script as well

Follow on from #182

Copy link
Contributor

@antnorwe : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit fa3aca9:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-monitor/agents/azure-monitor-agent-windows-client.md ✅Succeeded

For more details, please refer to the build report.

@Court72
Copy link
Contributor

Court72 commented Aug 27, 2025

@bwren

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Aug 27, 2025
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Sep 10, 2025
@v-dirichards
Copy link
Contributor

@bwren Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Sep 11, 2025
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Sep 25, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the authentication header configuration in the disassociate DCR script to handle the latest behavior of Get-AzAccessToken, which now returns tokens as secure strings instead of plain text.

  • Updated the authorization header construction to convert secure string tokens to plain text
  • Ensures compatibility with newer versions of the Azure PowerShell module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents/subsvc aq-pr-triaged C+L Pull Request Review Team label azure-monitor/svc Change sent to author do-not-merge inactive This PR is inactive for more than 14 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants