-
Notifications
You must be signed in to change notification settings - Fork 152
Fix ARM template documentation for Azure Arc machines in AgentSettings DCR setup #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
AgentSetting for Arc enabled machines
@ms-bakkali : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
@ms-bakkali : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit 5b6c1a2:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/azure-monitor/agents/azure-monitor-agent-manage.md | Details |
articles/azure-monitor/agents/azure-monitor-agent-manage.md
- Line 514, Column 1: [Warning: code-block-indented - See documentation]
Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
@ms-bakkali The warning will need to be cleared before we can merge. Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
@bwren Could you review this proposed update to your article and enter Thanks! |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes documentation for Azure Resource Manager template configuration when associating Data Collection Rules (DCR) with Azure Arc-enabled machines instead of standard Azure VMs.
- Adds a note clarifying the required scope property modification for Azure Arc machines
- Provides the correct resource type format for Arc machines (Microsoft.HybridCompute/machines)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Can you review this old PR and determine whether it needs to be closed or merged? @MicrosoftDocs/public-repo-pr-review-team |
This pull request updates the documentation for associating a Data Collection Rule (DCR) with a machine when using Azure Resource Manager templates.
Reason for change:
The current documentation only shows the scope property for Azure VMs:
"scope": "[format('Microsoft.Compute/virtualMachines/{0}', parameters('vmName'))]"
However, for Azure Arc-enabled machines, the scope must use Microsoft.HybridCompute/machines instead of Microsoft.Compute/virtualMachines.
What’s changed:
Added a clear note under the template section explaining the required modification for Azure Arc machines.
Provided the correct scope value for Arc machines:
"scope": "[format('Microsoft.HybridCompute/machines/{0}', parameters('name'))]"
Why this matters:
Without this change, deployments targeting Azure Arc machines will fail because the resource type in the scope property is incorrect.