Skip to content

Conversation

ms-bakkali
Copy link
Contributor

@ms-bakkali ms-bakkali commented Sep 11, 2025

This pull request updates the documentation for associating a Data Collection Rule (DCR) with a machine when using Azure Resource Manager templates.

Reason for change:
The current documentation only shows the scope property for Azure VMs:

"scope": "[format('Microsoft.Compute/virtualMachines/{0}', parameters('vmName'))]"

However, for Azure Arc-enabled machines, the scope must use Microsoft.HybridCompute/machines instead of Microsoft.Compute/virtualMachines.

What’s changed:
Added a clear note under the template section explaining the required modification for Azure Arc machines.
Provided the correct scope value for Arc machines:

"scope": "[format('Microsoft.HybridCompute/machines/{0}', parameters('name'))]"

Why this matters:
Without this change, deployments targeting Azure Arc machines will fail because the resource type in the scope property is incorrect.

image

Copy link
Contributor

@ms-bakkali : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

@ms-bakkali : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 5b6c1a2:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/azure-monitor/agents/azure-monitor-agent-manage.md ⚠️Warning Details

articles/azure-monitor/agents/azure-monitor-agent-manage.md

  • Line 514, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@v-dirichards
Copy link
Contributor

v-dirichards commented Sep 11, 2025

@ms-bakkali The warning will need to be cleared before we can merge.

@bwren

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Sep 11, 2025
@ms-bakkali
Copy link
Contributor Author

ms-bakkali commented Sep 12, 2025

there is also another issue with Doc

We don't mention how to deploy for scalability

The Azure built-in policies don't have anything for agentSetting

if a customer tries to do a DCR associate with a AgentSetting DCR, they will get an error

because the built-in DCR association policy Definition does not have AgentSetting field to validate again and compare for :

image

Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Sep 26, 2025
@v-dirichards
Copy link
Contributor

@bwren Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Sep 30, 2025
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Oct 14, 2025
@v-dirichards v-dirichards requested a review from Copilot October 14, 2025 21:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes documentation for Azure Resource Manager template configuration when associating Data Collection Rules (DCR) with Azure Arc-enabled machines instead of standard Azure VMs.

  • Adds a note clarifying the required scope property modification for Azure Arc machines
  • Provides the correct resource type format for Arc machines (Microsoft.HybridCompute/machines)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@v-dirichards
Copy link
Contributor

@bwren

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants