Skip to content

Updated defender-for-cloud-planning-and-operations-guide.md #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated defender-for-cloud-planning-and-operations-guide.md #56

wants to merge 1 commit into from

Conversation

AmichaiKlipstein
Copy link

Fixes and Improvements:

  1. Fixed typos, english errors.
  2. Fixed capitalization where needed.
  3. Restructured the Security RBAC section. Started with the concept and only then presented the example personas a whole, and not in two separate sections Note: The graphic needs fixing for english. In addition, there seemed to be inconsistency between Judy (Security Operations) and Sam (Security Analyst). Why does Judy require a Security Admin and not Sam? Both are required to dismiss alerts.
  4. Preserved Consistency with Defender for Cloud documentation - used the definitions from the 'Roles and Permissions' page for security reader and admin.
  5. Checked links, fixed text accordingly - many links did not lead to appropriate documentation.
  6. Fixed heading to gerunds from verbs where the section was not part of a procedure (for example, I changed Onboard non-Azure resources to Onboarding non-Azure resources)
  7. Adjusted heading levels to improve navigation and consistency throughout the document.

@AmichaiKlipstein
Update defender-for-cloud-planning-and-operations-guide.md
caecad3 
Fixes and Improvements:
1. Fixed typos, english errors.
2. Fixed capitalization where needed.
3. Restructured the Security RBAC section. Started with the concept and only then presented the example personas a whole, and not in two separate sections
**Note:** The graphic needs fixing for english. In addition, there seemed to be inconsistency between Judy (Security Operations) and Sam (Security Analyst). Why does Judy require a Security Admin and not Sam? Both are required to dismiss alerts.
4. Preserved Consistency with Defender for Cloud documentation - used the definitions from the 'Roles and Permissions' page for security reader and admin.
5. Checked links, fixed text accordingly - many links did not lead to appropriate documentation.
6. Fixed heading to gerunds from verbs where the section was not part of a procedure (for example, I changed Onboard non-Azure resources to Onboarding non-Azure resources)
7. Adjusted heading levels to improve navigation and consistency throughout the document.
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit caecad3:

✅ Validation status: passed

File Status Preview URL Details
articles/defender-for-cloud/defender-for-cloud-planning-and-operations-guide.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@AmichaiKlipstein
Copy link
Author

AmichaiKlipstein commented Mar 31, 2025 via email

@v-dirichards
Copy link
Contributor

@AmichaiKlipstein Could you please enter the needed comment for the CLA into GitHub directly? The response to the email doesn't work correctly.

@v-dirichards
Copy link
Contributor

@dcurwin

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@AmichaiKlipstein
Copy link
Author

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@v-dirichards
Copy link
Contributor

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@AmichaiKlipstein Could you please reply with @microsoft-github-policy-service agree? That is the command GitHub is waiting to see.

@AmichaiKlipstein
Copy link
Author

@microsoft-github-policy-service agree

@prmerger-automator prmerger-automator bot requested a review from dcurwin April 2, 2025 05:14
@prmerger-automator PRMerger Automator
Copy link
Contributor

@AmichaiKlipstein : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

1 similar comment
@prmerger-automator PRMerger Automator
Copy link
Contributor

@AmichaiKlipstein : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@github-actions GitHub Actions
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@v-dirichards
Copy link
Contributor

@dcurwin

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@github-actions github-actions bot removed the inactive label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcurwin dcurwin Awaiting requested review from dcurwin

Assignees

@dcurwin dcurwin

Labels
aq-pr-triaged Change sent to author defender-for-cloud/svc do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmichaiKlipstein @v-dirichards @dcurwin