-
Notifications
You must be signed in to change notification settings - Fork 424
Update cluster runtime upgrade with expand health check feature #3885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
deepukraju
wants to merge
3
commits into
MicrosoftDocs:main
Choose a base branch
from
deepukraju:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -77,6 +77,27 @@ az networkcloud baremetalmachine list -g $mrg --subscription $sub --query "sort_ | |||||
| --output table | ||||||
|
|
||||||
| ``` | ||||||
|
|
||||||
| ## Nexus tenant workload health check during cluster runtime upgrade | ||||||
|
|
||||||
| During a runtime upgrade, tenant workload (Nexus Kubernetes Cluster and Virtual Machine) health checks are performed for only rack by rack upgrade strategy. This functionality is feature flag enabled to control the cluster runtime upgrade outcome for health check failures. When the feature is enabled, the upgrade is paused if health check fails after the compute rack upgrade. The runtime upgrade can be resumed when customer executes the upgrade API [here](./howto-cluster-runtime-upgrade-with-pauserack-strategy.md). When the feature is disabled the upgrade continues to next stage even after the health check failure. By default the feature is disabled. | ||||||
|
|
||||||
| The tenant workload health checks are performed after different stages of cluster runtime upgrade like control-plane, management-plane and compute servers upgrade. It operates in snapshot and comparison modes and provides a mechanism to verify tenant workload health state after different stages of cluster runtime upgrade. | ||||||
|
|
||||||
| ### Workflow of tenant workload health check | ||||||
|
|
||||||
| 1. **Snapshot Initiation** - Snapshot is collected for tenant type Nexus Kubernetes Cluster and Virtual Machine, before starting upgrade of servers. | ||||||
| 2. **Upgrade Stage Transitions** - After upgrade of each stage like control-plane, management-plane and compute servers upgrade are completed, comparison of tenant workloads are initiated. | ||||||
| 3. **Comparison Process** - Comparison of current tenant workloads with snapshot taken during start of upgrade. Report comparison status. | ||||||
| 4. **Health Check Handling** - On success proceed to next runtime upgrade stage. For failure, based on feature flag is enable or disable its handled as below. | ||||||
|
|
||||||
| | Runtime upgrade Stage | Feature Enable | Feature Disable | | ||||||
| |--------------------------|----------------------------------------------------------------|---------------------------------| | ||||||
| | Initial Snapshot | Upgrade failure | Upgrade continues to next stage | | ||||||
| | Control Plane Upgrade | Upgrade failure | Upgrade continues to next stage | | ||||||
| | Management Plane Upgrade | Upgrade failure | Upgrade continues to next stage | | ||||||
| | Compute server Upgrade | Upgrade paused, resumed when customer executes the upgrade API | Upgrade continues to next stage | | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| ## BareMetalMachine (BMM) keyset operations during cluster runtime upgrade | ||||||
|
|
||||||
| When a server is upgraded to utilize a new OS, the BMM keysets have to be re-established with the new software. This process starts once the runtime upgrade completes for the instance. Servers yet to undergo a runtime upgrade can still be accessed via the BMM keyset. If access to a machine is needed during the upgrade, the console user is available. | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to reference the AFEC flag name here? (
EnableUpgradeInventoryChecks) or are we relying on other documentation elsewhere for that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added in TSG