RAC readiness check #3922
Open
RAC readiness check #3922
+154
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Learn Build status updates of commit 92a5d3e:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| [azure-local/deploy/media/New folder](https://github.com/ManikaDhiman/azure-stack-docs/blob/md-rac-lldp/azure-local/deploy/media/New folder) | Details | ||
| azure-local/deploy/rac-aware-cluster-readiness-check.md | Details | ||
| azure-local/deploy/media/New folder/sample-failed-test.png | ✅Succeeded | ||
| azure-local/deploy/media/New folder/sample-output-1.png | ✅Succeeded | ||
| azure-local/deploy/media/New folder/sample-output-2.png | ✅Succeeded |
[azure-local/deploy/media/New folder](https://github.com/ManikaDhiman/azure-stack-docs/blob/md-rac-lldp/azure-local/deploy/media/New folder)
- Line 0, Column 0: [Warning: folder-name-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in folder names. - Line 0, Column 0: [Suggestion: folder-name-incomplete - See documentation]
The folder name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
azure-local/deploy/rac-aware-cluster-readiness-check.md
- Line 97, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: './media/rack-aware-cluster-readiness-check/sample-failed-test.png'. - Line 144, Column 4: [Warning: file-not-found - See documentation]
Invalid file link: './media/rack-aware-cluster-readiness-check/sample-output-1.png'. - Line 152, Column 4: [Warning: file-not-found - See documentation]
Invalid file link: './media/rack-aware-cluster-readiness-check/sample-output-2.png'. - Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed. - Line 97, Column 1: [Suggestion: duplicate-alt-text - See documentation]
Alt text 'Screenshot of a sample output to check switch isolation.' is duplicated. Within an article, alt text must be unique. - Line 152, Column 4: [Suggestion: duplicate-alt-text - See documentation]
Alt text 'Screenshot of a sample output to check switch isolation.' is duplicated. Within an article, alt text must be unique.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
|
Learn Build status updates of commit bef2e9a: 💡 Validation status: suggestions
azure-local/deploy/rac-aware-cluster-readiness-check.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
|
Learn Build status updates of commit a027f5e: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
|
@ManikaDhiman : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces comprehensive documentation for using the LLDP validator to assess Rack Aware cluster deployment readiness in Azure Local. The documentation covers the validator's functionality, prerequisites, execution steps, and output interpretation.
Key Changes
- Added complete guide for LLDP validator usage in standalone mode
- Provided PowerShell code examples for running the validator with proper configuration
- Included sample outputs and JSON file descriptions for topology validation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| :::image type="content" source="./media/rack-aware-cluster-readiness-check/sample-output-1.png" alt-text="Screenshot of a sample output to check switch consistency." lightbox="./media/rack-aware-cluster-readiness-check/sample-output-1.png"::: | ||
|
|
||
| - Sample output of the validation test, **AzStackId_LLDP_Test_Cross_Zone_Switch_Isolation**. |
There was a problem hiding this comment.
Inconsistent naming: should be 'AzStackHCI_LLDP_Test_Cross_Zone_Switch_Isolation' to match the pattern used in line 138 ('AzStackHCI_LLDP_Test_Intra_Zone_Switch_Consistency').
Suggested change
| - Sample output of the validation test, **AzStackId_LLDP_Test_Cross_Zone_Switch_Isolation**. | |
| - Sample output of the validation test, **AzStackHCI_LLDP_Test_Cross_Zone_Switch_Isolation**. |
|
Can you review the proposed changes? Note that the following blocking issues need to be resolved: azure-local/deploy/rack-aware-cluster-readiness-check.md
If you approve the new content in this PR, the commits must be moved to the private repository for automated checks and publishing. After you move the commits, close this PR ( #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
|
Learn Build status updates of commit 6b980a9:
|
|
Learn Build status updates of commit 9a04d7c: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
mindyqdiep
reviewed
Oct 13, 2025
mindyqdiep
reviewed
Oct 13, 2025
mindyqdiep
reviewed
Oct 13, 2025
mindyqdiep
reviewed
Oct 13, 2025
rams1996
reviewed
Oct 17, 2025
rams1996
reviewed
Oct 17, 2025
rams1996
reviewed
Oct 17, 2025
rams1996
reviewed
Oct 17, 2025
rams1996
reviewed
Oct 17, 2025
| ``` | ||
|
|
||
| > [!IMPORTANT] | ||
| > Even if the LLDP validator reports a **SUCCESS** status, always manually review the detailed `AzStackHciEnvironmentReport` located in `$env:TEMP\LLDPValidation` (or your specified OutputPath) to ensure switch connection validations have been completed correctly. This report contains comprehensive information about network topology, connection consistency, and any configuration information that requires attention. |
There was a problem hiding this comment.
This is correct. It always reports success. We want to include some screenshots of how this can be seen
|
Learn Build status updates of commit 188b771: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.