-
Notifications
You must be signed in to change notification settings - Fork 964
Fix wrong links to "Heterogeneous Lookup in Associative Containers" #5396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix wrong links to "Heterogeneous Lookup in Associative Containers" #5396
Conversation
@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit fd729a9: ✅ Validation status: passed
For more details, please refer to the build report. |
@TylerMSFT - Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@@ -30,7 +30,7 @@ The element data type to be stored in the multimap. | |||
*`Traits`*\ | |||
The type that provides a function object that can compare two element values as sort keys to determine their relative order in the multimap. The binary predicate `less<Key>` is the default value. | |||
|
|||
In C++14 you can enable heterogeneous lookup by specifying the `std::less<>` or `std::greater<>` predicate that has no type parameters. For more information, see [Heterogeneous Lookup in Associative Containers](../standard-library/stl-containers.md#heterogeneous-lookup-in-associative-containers-c14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about removing the -c14?
When I look at the link in the browser, its #heterogeneous-lookup-in-associative-containers-c14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I added a custom anchor heterogeneous-lookup-in-associative-containers
, that will be used instead (i.e. without the "-c14"). The "-c14" is present in the browser as we don't have a custom anchor, and the default one is being used. I have cross checked with other instances and verified that doing #custom-anchor
works. Hope that clears it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rageking8 - I have a question about the removal of -c14. Looks like it is necessary. This is what I see when I copy the anchor link in the browser:
#heterogeneous-lookup-in-associative-containers-c14 <--- c14
@@ -39,7 +38,7 @@ Both `map` and `set` only allow one instance of a key or element to be inserted | |||
|
|||
Ordered maps and sets support bi-directional iterators, and their unordered counterparts support forward iterators. For more information, see [Iterators](../standard-library/iterators.md). | |||
|
|||
### Heterogeneous Lookup in Associative Containers (C++14) | |||
### <a name="heterogeneous-lookup-in-associative-containers"></a> Heterogeneous Lookup in Associative Containers (C++14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the aforementioned custom anchor.
Not sure why so many of these links point to the wrong
sequence_containers
anchor. Theheterogeneous-lookup-in-associative-containers
anchor is added as the defaultheterogeneous-lookup-in-associative-containers-c14
one might give wrong connotations about C (although C14 does not actually exist). Kebab case is chosen over snake case since the default one is as such.