Skip to content

Fix wrong links to "Heterogeneous Lookup in Associative Containers" #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Rageking8
Copy link
Contributor

Not sure why so many of these links point to the wrong sequence_containers anchor. The heterogeneous-lookup-in-associative-containers anchor is added as the default heterogeneous-lookup-in-associative-containers-c14 one might give wrong connotations about C (although C14 does not actually exist). Kebab case is chosen over snake case since the default one is as such.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit fd729a9:

✅ Validation status: passed

File Status Preview URL Details
docs/standard-library/map-class.md ✅Succeeded
docs/standard-library/multimap-class.md ✅Succeeded
docs/standard-library/multiset-class.md ✅Succeeded
docs/standard-library/set-class.md ✅Succeeded
docs/standard-library/stl-containers.md ✅Succeeded

For more details, please refer to the build report.

@v-regandowner
Copy link
Contributor

@TylerMSFT - Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jun 9, 2025
@@ -30,7 +30,7 @@ The element data type to be stored in the multimap.
*`Traits`*\
The type that provides a function object that can compare two element values as sort keys to determine their relative order in the multimap. The binary predicate `less<Key>` is the default value.

In C++14 you can enable heterogeneous lookup by specifying the `std::less<>` or `std::greater<>` predicate that has no type parameters. For more information, see [Heterogeneous Lookup in Associative Containers](../standard-library/stl-containers.md#heterogeneous-lookup-in-associative-containers-c14)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about removing the -c14?
When I look at the link in the browser, its #heterogeneous-lookup-in-associative-containers-c14

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I added a custom anchor heterogeneous-lookup-in-associative-containers, that will be used instead (i.e. without the "-c14"). The "-c14" is present in the browser as we don't have a custom anchor, and the default one is being used. I have cross checked with other instances and verified that doing #custom-anchor works. Hope that clears it up.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rageking8 - I have a question about the removal of -c14. Looks like it is necessary. This is what I see when I copy the anchor link in the browser:
#heterogeneous-lookup-in-associative-containers-c14 <--- c14

@@ -39,7 +38,7 @@ Both `map` and `set` only allow one instance of a key or element to be inserted

Ordered maps and sets support bi-directional iterators, and their unordered counterparts support forward iterators. For more information, see [Iterators](../standard-library/iterators.md).

### Heterogeneous Lookup in Associative Containers (C++14)
### <a name="heterogeneous-lookup-in-associative-containers"></a> Heterogeneous Lookup in Associative Containers (C++14)
Copy link
Contributor Author

@Rageking8 Rageking8 Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the aforementioned custom anchor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants