Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address comments on PR 2069 "Move samples repos Readme content into regular Docs" #2178

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Sep 15, 2022

This forked PR addresses the review comments on PR #2069. Recomm. updating that PR from main.
This PR is based on the branch for PR 2069. It's been updated from origin/main upon creation.

JasonAndrewWriter and others added 30 commits August 8, 2022 09:41
Co-authored-by: Michael Hoffman <[email protected]>
Co-authored-by: Michael Hoffman <[email protected]>
Co-authored-by: Michael Hoffman <[email protected]>
Co-authored-by: Michael Hoffman <[email protected]>
Co-authored-by: Michael Hoffman <[email protected]>
Co-authored-by: Michael Hoffman <[email protected]>
Co-authored-by: Michael Hoffman <[email protected]>
Co-authored-by: Michael Hoffman <[email protected]>
Co-authored-by: Michael Hoffman <[email protected]>
Provide additional detail for customers looking for the background and how the "Share OS Regional Settings" feature works in the web platform.
I just did @michael's edits and then mine.
Michael Hoffman and others added 25 commits September 1, 2022 10:16
…0-4a85-bd0e-46c107c3cfcc_66

[METADATA UPDATE] Global metadata changes
* Update to the WCO docs

* Update microsoft-edge/progressive-web-apps-chromium/how-to/window-controls-overlay.md

Co-authored-by: Michael Hoffman <[email protected]>

Co-authored-by: Michael Hoffman <[email protected]>
* Improving the CSS Overview docs (part 1)

* Improving the CSS Overview docs (part 2)

* Updating ms.date

* Changed title to address review comment
…i3-ga-update

Roadmap update for WinUI3 GA
…oftDocs#2153)

* Release Note for WebView2 with Stable 105 and Pre-release 106

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael S. Hoffman <[email protected]>

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael S. Hoffman <[email protected]>

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael S. Hoffman <[email protected]>

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael S. Hoffman <[email protected]>

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael S. Hoffman <[email protected]>

* release notes h2 added

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael Hoffman <[email protected]>

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael Hoffman <[email protected]>

* fixing bug fixes

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael Hoffman <[email protected]>

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael Hoffman <[email protected]>

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael Hoffman <[email protected]>

* Update microsoft-edge/webview2/release-notes.md

Co-authored-by: Michael Hoffman <[email protected]>

* Update release-notes.md

* Update release-notes.md

Co-authored-by: Jason Andrew <[email protected]>
Co-authored-by: Michael S. Hoffman <[email protected]>
Co-authored-by: JasonAndrewWriter <[email protected]>
Co-authored-by: Michael Hoffman <[email protected]>
* add inline icons

* add new screenshots

* fix link to screenshot

* add screenshot, tweak

* fix note and date

* add info for SameParty and Partition Key

* add original screenshots, roll back procedure step

* touch date

* delete Focus mode files for cookies doc

* removed Focus Mode icon

* Apply suggestions from code review

commit suggestions from Michael

Co-authored-by: Michael Hoffman <[email protected]>

* Apply suggestions from code review

changes from Michael and Patrick

Co-authored-by: Michael Hoffman <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>

* Apply suggestions from code review

accept

Co-authored-by: Michael Hoffman <[email protected]>

* Apply suggestions from code review

edits from Michael

Co-authored-by: Michael Hoffman <[email protected]>

Co-authored-by: Michael Hoffman <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
* Adding quick fix documenation

* Writer/Editor pass

* Merged lists

* Intro to list

* tech corrections

* Adding new screenshots in light and dark

* Update microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension.md

Co-authored-by: Michael Hoffman <[email protected]>

* add -light to png

* Add -light to png name locally

* Removed unused pngs (MicrosoftDocs#2170)

* Remove unused pngs

* Joined intro sentences

Co-authored-by: Michael S. Hoffman <[email protected]>
Co-authored-by: Reezaali <[email protected]>
* Add videos to Customize

* Add welcome text

* Move section down, copy markup/pngs from videos page

* Re-add Welcome text incl 'customize'
@mikehoffms mikehoffms changed the base branch from main to user/v-mhoffman/readmes-content September 15, 2022 01:30
@opbld32
Copy link

opbld32 commented Sep 15, 2022

Docs Build status updates of commit 49c8c37:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/media/windows-keyboard-logo.png ✅Succeeded View
microsoft-edge/toc.yml ✅Succeeded View
microsoft-edge/webview2/code-samples-links.md ✅Succeeded View
microsoft-edge/webview2/concepts/basic-authentication.md ✅Succeeded View
microsoft-edge/webview2/concepts/distribution.md ✅Succeeded View
microsoft-edge/webview2/concepts/navigation-events.md ✅Succeeded View
microsoft-edge/webview2/concepts/process-model.md ✅Succeeded View
microsoft-edge/webview2/concepts/threading-model.md ✅Succeeded View
microsoft-edge/webview2/get-started/get-started.md ✅Succeeded View
microsoft-edge/webview2/get-started/media/vs2022-create-a-new-project.png ✅Succeeded n/a (file deleted)
microsoft-edge/webview2/get-started/media/wpf-getting-started-mng-nuget.png ✅Succeeded n/a (file deleted)
microsoft-edge/webview2/get-started/win32.md ✅Succeeded View
microsoft-edge/webview2/get-started/winforms.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui2.md ✅Succeeded View
microsoft-edge/webview2/get-started/wpf.md ✅Succeeded View
microsoft-edge/webview2/how-to/chromium-devtools-protocol.md ✅Succeeded View
microsoft-edge/webview2/how-to/hostobject.md ✅Succeeded View
microsoft-edge/webview2/how-to/machine-setup.md ✅Succeeded View
microsoft-edge/webview2/how-to/winrt-from-js.md ✅Succeeded View
microsoft-edge/webview2/index.md ✅Succeeded View
microsoft-edge/webview2/samples/deployment-samples.md ✅Succeeded View
microsoft-edge/webview2/samples/media/unsupported-review-project-dialog.png ✅Succeeded View
microsoft-edge/webview2/samples/media/webview2apisample-app-window.png ✅Succeeded n/a (file deleted)
microsoft-edge/webview2/samples/media/webview2apisample-in-solution-explorer.png ✅Succeeded n/a (file deleted)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Sep 15, 2022

Docs Build status updates of commit 49c8c37:

✅ Validation status: passed

File Status Preview URL Details
CONTRIBUTING.md ✅Succeeded
microsoft-edge/developer/index.yml ✅Succeeded View
microsoft-edge/develop-web-microsoft-edge.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/about-tools.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/css-overview-tool.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-clear.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-contrast-issues.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-contrast-issues-elements.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-contrast-issues-elements-tool.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-elements-tool.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-font-element.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-media-query.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-open.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-report.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-scroll.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-sources-tool.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/css/images/css-overview-tool-welcome.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/customize/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/customize/index-images/customize-devtools.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/customize/index-images/learn-devtools-ui.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/experimental-features/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/landing/index.yml ✅Succeeded View
microsoft-edge/devtools-guide-chromium/network-console/images/edit-and-resend.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/network-console/images/edit-then-send.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/network-console/images/entering-key-value-pairs.png ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@mikehoffms mikehoffms changed the title PR into PR 2069 "Move samples repos Readme content into regular Docs" Address comments on PR 2069 "Move samples repos Readme content into regular Docs" Sep 15, 2022
@captainbrosset captainbrosset merged commit c1b2aac into MicrosoftDocs:user/v-mhoffman/readmes-content Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.