Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc Improvement][Entra ID fix][4321625] #12521

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

v-shalinir
Copy link
Collaborator

Configure access token version before app ID URI

Configure access token version before app ID URI
@acrolinxatmsft1

This comment was marked as outdated.

This comment was marked as outdated.

Move Configure access token version before app ID URI
@acrolinxatmsft1

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinxatmsft1

This comment was marked as outdated.

This comment was marked as outdated.

Move configure access token version before configuration of app ID URI
@acrolinxatmsft1

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinxatmsft1

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinxatmsft1

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinxatmsft1

This comment was marked as outdated.

This comment was marked as outdated.

@v-shalinir v-shalinir marked this pull request as draft March 21, 2025 06:40
@v-shalinir v-shalinir changed the title [Doc Improvement][Entra ID fix] [Doc Improvement][Entra ID fix][4321625] Mar 21, 2025
@acrolinxatmsft1

This comment was marked as outdated.

Copy link
Contributor

Learn Build status updates of commit f2e23e7:

✅ Validation status: passed

File Status Preview URL Details
msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md ✅Succeeded View
msteams-platform/concepts/authentication/nested-authentication.md ✅Succeeded View
msteams-platform/messaging-extensions/api-based-microsoft-entra.md ✅Succeeded View
msteams-platform/tabs/how-to/authentication/tab-sso-register-aad.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

* [Authenticate token](#authenticate-token).
* [Configure scope for access token](#configure-scope-for-access-token).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this page specifically, I don't think you want to move 'Configure scope for access token' step to be after 'authenticate token' step. The configure scope for access token step is a prerequisite before you can acquire the token and validate it.

Instead, I think you want to add another step, 'set access token version', and put that before the 'configure scope for access token' step. There, have them set the access token version to 2 using the manifest (same as you have for other articles). Then the rest of the steps in order - configure the scope, then authenticate token, etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to check the procedure for updating the access token version number in Azure portal. There's a new manifest version and there are some updates:
The property name has changed from accessTokenAcceptedVersion to requestedAccessTokenVersion.
It seems that this property is set to 2, by default.

This update will impact all the SSO topics. The procedure of configuring access token may change to just verifying that access token is set to 2.

@acrolinx-at-msft2

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinx-at-msft2

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinx-at-msft2

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinx-at-msft2

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinx-at-msft2

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinx-at-msft2

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinx-at-msft2

This comment was marked as outdated.

This comment was marked as outdated.

@acrolinx-at-msft2
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md 86 90 link
msteams-platform/concepts/authentication/nested-authentication.md 92 17 link
msteams-platform/messaging-extensions/api-based-microsoft-entra.md 93 20 link
msteams-platform/tabs/how-to/authentication/tab-sso-register-aad.md 89 35 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

@acrolinx-at-msft2
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md 86 90 link
msteams-platform/concepts/authentication/nested-authentication.md 92 17 link
msteams-platform/messaging-extensions/api-based-microsoft-entra.md 93 20 link
msteams-platform/tabs/how-to/authentication/tab-sso-register-aad.md 89 35 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

@acrolinx-at-msft2
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/bots/how-to/authentication/bot-sso-register-aad.md 86 90 link
msteams-platform/concepts/authentication/nested-authentication.md 92 17 link
msteams-platform/messaging-extensions/api-based-microsoft-entra.md 93 20 link
msteams-platform/tabs/how-to/authentication/tab-sso-register-aad.md 89 35 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants