[Doc Improvement][Securing-bot-teams-channel-content] #12718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
v-shalinir
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Hello. I don't have any involvement with this doc set. But just as an observation, in terms of telling people where to go for new bot/agent creation, I would not point them to Azure Bot Framework SDK.
I would probably point people toward Agents SDK instead: https://learn.microsoft.com/en-us/microsoft-365/agents-sdk/
However, in terms of pointing toward general information about Azure Bot Service items like app service resources, bot resources, channel registration, there you can point to the ABF/ABS docs, since that's the only place the Azure Bot Service is documented.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Acrolinx ScorecardsWe currently enforce a minimum score of 80. Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:
More info about Acrolinx Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Acrolinx ScorecardsWe currently enforce a minimum score of 80. Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:
More info about Acrolinx Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally. |
|
Learn Build status updates of commit 6da26d8:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| msteams-platform/bots/securing-bot-teams-channel-content.md | View | Details | |
| msteams-platform/assets/images/bots/nw-architecture-secure-bot.png | ✅Succeeded | View | |
| msteams-platform/assets/images/bots/restrict-egress-rules.png | ✅Succeeded | View | |
| msteams-platform/assets/images/bots/restrict-ingress-rules.png | ✅Succeeded | View | |
| msteams-platform/bots/secure-bots-in-teams.md | ✅Succeeded | View | |
| msteams-platform/TOC.yml | ✅Succeeded | View |
msteams-platform/bots/securing-bot-teams-channel-content.md
- Line 17, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: 'media/securing-bot-image-001.svg'. - Line 31, Column 233: [Warning: file-not-found - See documentation]
Invalid file link: '../../networking/architecture/hub-spoke.yml'. - Line 83, Column 291: [Warning: file-not-found - See documentation]
Invalid file link: '../../best-practices/auto-scaling.md'. - Line 149, Column 7: [Warning: file-not-found - See documentation]
Invalid file link: 'media/securing-bot-image-002.png'. - Line 189, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: 'media/securing-bot-image-003.png'. - Line 263, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: 'media/securing-bot-image-004.png'. - Line 267, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: 'media/securing-bot-image-005.png'. - Line 269, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: 'media/securing-bot-image-006.png'. - Line 271, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: 'media/securing-bot-image-007.png'. - Line 301, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: 'media/securing-bot-image-009.png'. - Line 365, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: 'media/securing-bot-image-010.png'. - Line 367, Column 5: [Warning: file-not-found - See documentation]
Invalid file link: 'media/securing-bot-image-011.png'. - Line 385, Column 13: [Warning: file-not-found - See documentation]
Invalid file link: '../../browse/index.yml'. - Line 387, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: '../firewalls/index.yml'. - Line 389, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: '../aadsec/azure-ad-security.yml'. - Line 391, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: '../data/sentinel-threat-intelligence.yml'. - Line 393, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: '../../networking/architecture/hub-spoke.yml'. - Line 39, Column 3: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /azure/bot-service/?view=azure-bot-service-4.0 - Line 39, Column 187: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /azure/bot-service/bot-service-manage-channels?view=azure-bot-service-4.0 - Line 105, Column 163: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /microsoft-365/enterprise/urls-and-ip-address-ranges?view=o365-worldwide#skype-for-business-online-and-microsoft-teams - Line 191, Column 4: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /azure/bot-service/bot-builder-tutorial-create-basic-bot?view=azure-bot-service-4.0&tabs=csharp%2Cvs - Line 381, Column 14: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: /azure/bot-service/index-bf-sdk?view=azure-bot-service-4.0
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.