Skip to content

[Doc Improvement][Update localization.json] #12738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

v-santhoshs1
Copy link
Collaborator

No description provided.

@acrolinx-at-msft2
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/concepts/build-and-test/apps-localization.md 88 11 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit 5b0543c:

✅ Validation status: passed

File Status Preview URL Details
msteams-platform/concepts/build-and-test/apps-localization.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@v-santhoshs1 v-santhoshs1 changed the title [Doc Improvement][Update localization.json occurances] [Doc Improvement][Update localization.json] Apr 24, 2025
@v-santhoshs1 v-santhoshs1 requested a review from v-shalinir April 25, 2025 05:18
v-srmurugan
v-srmurugan previously approved these changes Apr 25, 2025
@v-srmurugan v-srmurugan self-requested a review April 25, 2025 11:03
@acrolinx-at-msft2
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/concepts/build-and-test/apps-localization.md 88 11 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit b4d40fd:

✅ Validation status: passed

File Status Preview URL Details
msteams-platform/concepts/build-and-test/apps-localization.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@acrolinx-at-msft2
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/concepts/build-and-test/apps-localization.md 88 11 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit 4b054a6:

✅ Validation status: passed

File Status Preview URL Details
msteams-platform/concepts/build-and-test/apps-localization.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@acrolinx-at-msft2
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/concepts/build-and-test/apps-localization.md 88 11 link
msteams-platform/resources/schema/manifest-schema.md 85 139 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit 505f6ad:

✅ Validation status: passed

File Status Preview URL Details
msteams-platform/concepts/build-and-test/apps-localization.md ✅Succeeded View
msteams-platform/resources/schema/manifest-schema.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 505f6ad:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 505f6ad8679e8154d5c7c5139879824b4bfb2e53 in branch doc-improvement-localization.json of repository https://github.com/MicrosoftDocs/msteams-docs into branch main (commit 7ece28d333d7782a28a1e2cc9c8b21c75eca59fd). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@acrolinx-at-msft2
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/concepts/build-and-test/apps-localization.md 88 11 link
msteams-platform/resources/schema/manifest-schema.md 85 139 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

@acrolinx-at-msft2
Copy link
Collaborator

Acrolinx Scorecards

We currently enforce a minimum score of 80.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Score Issues Scorecard Processed
msteams-platform/concepts/build-and-test/apps-localization.md 88 11 link
msteams-platform/resources/schema/manifest-schema.md 85 140 link

More info about Acrolinx

Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Copy link
Contributor

Learn Build status updates of commit c54508d:

✅ Validation status: passed

File Status Preview URL Details
msteams-platform/concepts/build-and-test/apps-localization.md ✅Succeeded View
msteams-platform/resources/schema/manifest-schema.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@AjayJ12-MSFT
Copy link

AjayJ12-MSFT commented May 5, 2025

The localization for custom apps is currently not functioning on the Teams platform, which is blocking us from testing the latest manifest updates. We have raised a bug for the issue and waiting for response from the engineering team

Bug Link: Bug 4440259: Teams App Localization Not Reflecting

Copy link
Collaborator

@ChetanSharma-msft ChetanSharma-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my review comments.

@@ -67,9 +67,9 @@ The following `manifest.json` helps to add the `localizationInfo` property with
}
```

### Example localization .json change
### Example localization.json change
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the versions of it and update those accordingly.
Currently we are using different versions.

"$schema": "https://developer.microsoft.com/json-schemas/teams/v1.5/MicrosoftTeams.schema.json",
"manifestVersion": "1.5",
"$schema": "https://developer.microsoft.com/json-schemas/teams/v1.21/MicrosoftTeams.schema.json",
"manifestVersion": "1.21",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this localization is working after doing version changes for manifest schema and localization schema?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Ajay: This is a platform issue where the localization is not working. An issue/bug is raised for the same.

"$schema": "https://developer.microsoft.com/json-schemas/teams/v1.5/MicrosoftTeams.Localization.schema.json",
"manifestVersion": "1.5",
"$schema": "https://developer.microsoft.com/json-schemas/teams/v1.21/MicrosoftTeams.Localization.schema.json",
"manifestVersion": "1.21",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this localization is working after doing version changes for manifest schema and localization schema?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chetan it's not working on older as well as latest version and other user have also reported this issue we have raised a bug for that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChetanSharma-msft - Ajay is yet to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localization.json versions should be consistent in the documentation
6 participants