fix: mitigate command injection risk in background tasks workflow#13673
Open
MatrixNeoKozak wants to merge 1 commit into
Open
fix: mitigate command injection risk in background tasks workflow#13673MatrixNeoKozak wants to merge 1 commit into
MatrixNeoKozak wants to merge 1 commit into
Conversation
Contributor
|
Learn Build status updates of commit 6dcc62e: ✅ Validation status: passed
For more details, please refer to the build report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the GitHub Actions workflow
BackgroundTasks.yml, theSave payload datastep expands thePayloadJsonenvironment variable directly in a bash command viaecho $PayloadJson. Because this workflow is triggered onpull_request_target, an external contributor can control properties within thegithubcontext (such as pull request titles, descriptions, or branch names). If any of these fields contain special characters like semicolons, backticks, or shell evaluation sequences, they are evaluated by the shell, leading to a command injection vulnerability. This is resolved by writing the environment variable directly usingprintenv PayloadJson > ./pr/PayloadJson.json, which avoids shell evaluation of the variable's contents.