This repository was archived by the owner on Feb 24, 2021. It is now read-only.
Adding SVG recipes as well as modification to cssUsage.js to allow a flag for stripping the url value #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
March 23, 2017 17:00
… the recipe file. Need to fix grunt because it's overwriting things I'm doing in cssUsage.js
|
This also fixes #39 |
gregwhitworth
suggested changes
Nov 21, 2017
There was a problem hiding this comment.
Can you please place the svg file into a /resources sub folder rather than in the root. Additionally, why did you delete the recipe-template.js - please put it back. Finally, please add some unit tests for createValueArray() that test what you implemented so that other people don't regress it in the future.
|
This is still open for some reason, closing it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SVG recipes as well as modification to cssUsage.js to allow a flag for stripping the url value