Barcelona | Oct-2025-02| Joseph Ayitey | Sprint 2 | Form Controls #45
+77
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvcds
reviewed
Nov 18, 2025
| </form> | ||
| <p>Please fill in the form below:</p> | ||
| <form action="#" method="post"> | ||
| <div> |
There was a problem hiding this comment.
For reading, it's better to align this properly, othere than this LGTM (look good to me)
mvcds
approved these changes
Nov 18, 2025
LucaPipolo
reviewed
Nov 18, 2025
| <p>Please fill in the form below:</p> | ||
| <form action="#" method="post"> | ||
| <div> | ||
| <label for="fullName">Full name</label> |
There was a problem hiding this comment.
Very minor User Experience tip: if the fields are required, consider adding a * in the label to communicate the user what you expect. Like <label for="email">Email*:</label>
For more info, have a look to Google accessibility tips here: "Labels inform a user about the purpose of a field, if the field is required […]".
Author
There was a problem hiding this comment.
Thanks for your tips, its really helpful.. Thanks for reviewing my works and helping out. i do appreciate..
So its good when i introduce *. As you indicated, or only when the field is required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
In this project, i was able to use the semantic elements, but further on with divs to put in a proper arrangement. Also, i modify the footer and header. The form was built without Css or javascripts, only the html element.
Questions
Ask any questions you have for your reviewer.
First of all, thanks for the time to review.. here are some few questions;