[BT-1]: Product CRUD created #1
Conversation
There was a problem hiding this comment.
Excelent first try!
Remember in order to merge your PR all your code must be covered by unit tests.
One more recommendation: Add interfaces for your service and your repository.. so your controller depends on the interface of the service and the service depends on the interface of the repository, not on the implementations
backend/pom.xml
Outdated
| <name>Backend</name> | ||
| <description>Demo project for Spring Boot</description> | ||
| <url /> | ||
| <licenses> |
There was a problem hiding this comment.
I recommend to remove the entries that you're not using: url, licenses, developers, scm
| public class BackendApplication { | ||
|
|
||
| public static void main(String[] args) { | ||
| SpringApplication.run(BackendApplication.class, args); |
There was a problem hiding this comment.
Review the settings of your IDE, it's using tabs for identation, usually we use 2 or 3 spaces
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController | ||
| public class HelloWorldController { |
There was a problem hiding this comment.
I recommend to remove this class as it was just for testing and shouldn't belong to your project.
| @RequestMapping("/products") | ||
| public class ProductController { | ||
|
|
||
| ProductService productService = new ProductService(); |
There was a problem hiding this comment.
don't forget the access modifier (private).
You must not instantiate your ProductService by yourself, spring boot manage the instances of your beans and will inject them wherever you require it
| } | ||
|
|
||
| @PostMapping("/{id}/outofstock") | ||
| public Product outOfStock(@PathVariable Long id) { |
There was a problem hiding this comment.
What does this method do? .. The name is not descriptive at all (same for inStock)
| return null; | ||
| } | ||
|
|
||
| public Product updateStock(Long id, int stock) { |
There was a problem hiding this comment.
update stock is business logic, that logic belongs to a service layer not repository layer.
|
|
||
| import java.util.Optional; | ||
|
|
||
| public class ProductService { |
There was a problem hiding this comment.
Annotate this class with @Service
| import java.util.Optional; | ||
|
|
||
| public class ProductService { | ||
| private ProductRepository productRepository = new ProductRepository(); |
There was a problem hiding this comment.
Don't instantiate ProductRepository by yourself, let spring boot do that job
| } | ||
|
|
||
| public Product outOfStock(Long id) { | ||
| return productRepository.updateStock(id, 0); |
There was a problem hiding this comment.
see comment about updateStock in repository class
| @@ -0,0 +1,2 @@ | |||
| spring.application.name=Backend | |||
There was a problem hiding this comment.
Prefer yml format.
I recommend to rename the file from application.properties to application.yml
No description provided.