Skip to content

Issue-94 Resolved memory leak by adding weak to parent CameraManager #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Issue-94 Resolved memory leak by adding weak to parent CameraManager #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Internal/Manager/CameraManager+MotionManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import CoreMotion
import AVKit

@MainActor class CameraManagerMotionManager {
private(set) var parent: CameraManager!
private(set) weak var parent: CameraManager!
private(set) var manager: CMMotionManager = .init()
}

Expand Down
2 changes: 1 addition & 1 deletion Sources/Internal/Manager/CameraManager+NotificationCenter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import Foundation

@MainActor class CameraManagerNotificationCenter {
private(set) var parent: CameraManager!
private(set) weak var parent: CameraManager!
}

// MARK: Setup
Expand Down
2 changes: 1 addition & 1 deletion Sources/Internal/Manager/CameraManager+PhotoOutput.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import AVKit

@MainActor class CameraManagerPhotoOutput: NSObject {
private(set) var parent: CameraManager!
private(set) weak var parent: CameraManager!
private(set) var output: AVCapturePhotoOutput = .init()
}

Expand Down
2 changes: 1 addition & 1 deletion Sources/Internal/Manager/CameraManager+VideoOutput.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import SwiftUI
import MijickTimer

@MainActor class CameraManagerVideoOutput: NSObject {
private(set) var parent: CameraManager!
private(set) weak var parent: CameraManager!
private(set) var output: AVCaptureMovieFileOutput = .init()
private(set) var timer: MTimer = .init(.camera)
private(set) var recordingTime: MTime = .zero
Expand Down
2 changes: 1 addition & 1 deletion Sources/Internal/UI/Camera View/CameraView+Grid.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import SwiftUI

class CameraGridView: UIView {
var parent: CameraManager!
weak var parent: CameraManager!
}

// MARK: Setup
Expand Down
2 changes: 1 addition & 1 deletion Sources/Internal/UI/Camera View/CameraView+Metal.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import MetalKit
import AVKit

@MainActor class CameraMetalView: MTKView {
private(set) var parent: CameraManager!
private(set) weak var parent: CameraManager!
private(set) var ciContext: CIContext!
private(set) var commandQueue: MTLCommandQueue!
private(set) var currentFrame: CIImage?
Expand Down