Skip to content

Check HDR mode supported #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check HDR mode supported #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Sources/Internal/Manager/Helpers/Capture Device/CaptureDevice+AVCaptureDevice.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ extension AVCaptureDevice: CaptureDevice {
var maxISO: Float { activeFormat.maxISO }
var minFrameRate: Float64? { activeFormat.videoSupportedFrameRateRanges.first?.minFrameRate }
var maxFrameRate: Float64? { activeFormat.videoSupportedFrameRateRanges.first?.maxFrameRate }
var isVideoHDRSupported: Bool { activeFormat.isVideoHDRSupported }
}

// MARK: Getters & Setters
Expand All @@ -34,6 +35,7 @@ extension AVCaptureDevice {
else { return .off }
}
set {
guard isVideoHDRSupported else { return }
automaticallyAdjustsVideoHDREnabled = newValue == .auto
if newValue != .auto { isVideoHDREnabled = newValue == .on }
}
Expand Down
1 change: 1 addition & 0 deletions Sources/Internal/Manager/Helpers/Capture Device/CaptureDevice+MockCaptureDevice.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ class MockCaptureDevice: NSObject, CaptureDevice {
var hasTorch: Bool { true }
var isExposurePointOfInterestSupported: Bool { true }
var isFocusPointOfInterestSupported: Bool { true }
var isVideoHDRSupported: Bool { true }

// MARK: Setters
var videoZoomFactor: CGFloat = 1
Expand Down
1 change: 1 addition & 0 deletions Sources/Internal/Manager/Helpers/Capture Device/CaptureDevice.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ protocol CaptureDevice: NSObject {
var hasTorch: Bool { get }
var isExposurePointOfInterestSupported: Bool { get }
var isFocusPointOfInterestSupported: Bool { get }
var isVideoHDRSupported: Bool { get }

// MARK: Getters & Setters
var videoZoomFactor: CGFloat { get set }
Expand Down