Skip to content

Switch coverage from Codecov to Coveralls, raise to 88%#10

Merged
dkijania merged 2 commits intomasterfrom
improve/project-quality
Apr 18, 2026
Merged

Switch coverage from Codecov to Coveralls, raise to 88%#10
dkijania merged 2 commits intomasterfrom
improve/project-quality

Conversation

@dkijania
Copy link
Copy Markdown
Member

@dkijania dkijania commented Apr 16, 2026

Summary

  • Replace Codecov with Coveralls. The previous setup silently failed uploads (tokenless requests rejected, `fail_ci_if_error: false`) so the dashboard was empty and the badge stayed at "unknown". Coveralls uses `GITHUB_TOKEN` automatically for public repos — no secret to configure.
  • Run `client_tests.rs` in the coverage job. Previously only `--lib` ran, which meant the 21 wiremock tests for `src/client.rs` were never counted. Adding `--test client_tests` raised line coverage from 18% → 88% locally (src/client.rs went from 0/232 to 209/232).
  • Exclude `examples/` and `tests/` from the coverage calculation so the report reflects the library surface only.
  • Switch the README badge to Coveralls.
  • `.gitignore` tarpaulin's generated artifacts.

One-time setup needed

Enable the repo at https://coveralls.io (log in with GitHub → toggle `MinaProtocol/mina-sdk-rust` on). No token to add to the repo — the action uses `GITHUB_TOKEN`.

Test plan

  • `cargo tarpaulin --lib --test client_tests --out lcov --skip-clean --exclude-files 'examples/' --exclude-files 'tests/'` runs locally (88.29% coverage).
  • Verify Coveralls receives the upload after merge to master.

🤖 Generated with Claude Code

@dkijania dkijania changed the title Add Codecov badge to README Switch coverage from Codecov to Coveralls, raise to 88% Apr 17, 2026
dkijania and others added 2 commits April 18, 2026 08:09
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
- Use Coveralls instead of Codecov: the previous setup uploaded to Codecov
  without a token, got rejected, and silently passed CI (fail_ci_if_error
  was false) — so the dashboard and badge were empty. Coveralls picks up
  GITHUB_TOKEN automatically for public repos, no secret to configure.
- Run client_tests.rs alongside the lib unit tests so src/client.rs is
  actually exercised (raised coverage from 18% to 88% locally). Keep
  integration_tests.rs out of the coverage job since it needs a live daemon.
- Exclude examples/ and tests/ from the coverage report.
- Switch the README badge to Coveralls.
- .gitignore the generated tarpaulin artifacts.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@dkijania dkijania force-pushed the improve/project-quality branch from 9809a53 to f2b9553 Compare April 18, 2026 06:11
@dkijania dkijania merged commit a482219 into master Apr 18, 2026
5 checks passed
@dkijania dkijania deleted the improve/project-quality branch April 18, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant