Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwind all config loading changes since last release #16547

Open
wants to merge 15 commits into
base: compatible
Choose a base branch
from
Open

Unwind all config loading changes since last release #16547

wants to merge 15 commits into from

Conversation

mrmr1993
Copy link
Member

This PR unwinds all the changes around loading configurations since the last release. This is a more aggressive version of #16546.

This PR was created by reverting the merges of each of a short list of offending PRs:

git revert -m 1 a2aac90c3b93e00515d265ca142634a26422d15e
git revert -m 1 6c93aa928aece8dcbd3de11200bf09a643fff8bc
git revert -m 1 c3c7c34b0719c016239f83c770603eb7768f9adc
git revert -m 1 c701a315ad9b2997250d5f577232c8de839f552c
git revert -m 1 ec43a6b7eaaf4b1acc9e9dc812cd19f5311f51d2
git revert -m 1 c130dfab6b7a99ed882e293540876ac95a1ff599
git revert -m 1 8a2a077d80aac3ed5181a694e1f2aa841a9e15e7
git revert -m 1 e130ac77a50149ebb0ff3840e4ac5dae32afe201
git revert -m 1 0b1293261ae9d170244a57eb0d3656e0add8dfef
git revert -m 1 6df5977c39b37653eb8360f63448fcb033a485f3

Some of these have small conflicts, mostly generated from the merge with #16093.

The remaining commits are to fix compilation failures after the reverts, except for 1bb57d6 which takes a more opinionated approach to actually propagate and use the runtime config's values for the implementation from #16093.

mrmr1993 added 14 commits January 28, 2025 23:40
@mrmr1993
Revert "Merge pull request #16538 from MinaProtocol/feature/stop-usel…
efe6049 
…ess-logging"

This reverts commit a2aac90, reversing
changes made to 9b8de11.
@mrmr1993
Revert "Merge pull request #16512 from MinaProtocol/georgeee/redo-161…
9bcecb5 
…86-after-review-fixes"

This reverts commit 6c93aa9, reversing
changes made to c7e6fc2.
@mrmr1993
Revert "Merge pull request #16403 from MinaProtocol/sai/removing-logg…
939896b 
…ing-from-cfg-loading"

This reverts commit c3c7c34, reversing
changes made to 40c86e2.
@mrmr1993
Revert "Merge pull request #16381 from MinaProtocol/sai/fix-compile-c…
af4dfb8 
…onfig-logging"

This reverts commit c701a31, reversing
changes made to 9dbaa6d.
@mrmr1993
Revert "Merge pull request #16356 from MinaProtocol/martin/provide-fu…
246dfb1 
…ll-rt-config-to-graphql"

This reverts commit ec43a6b, reversing
changes made to 4ac4143.
@mrmr1993
Revert "Merge pull request #16304 from MinaProtocol/martin/remove-red…
4b7875e 
…undant-fields-from-compile_config-type"

This reverts commit c130dfa, reversing
changes made to ecc244a.
@mrmr1993
Revert "Merge pull request #16196 from MinaProtocol/martin/force-unco…
3d3d756 
…nfigurable_constants-to-toplevel"

This reverts commit 8a2a077, reversing
changes made to e130ac7.
@mrmr1993
Revert "Merge pull request #16186 from MinaProtocol/martin/create-con…
ec5a56d 
…stants-loader-part-1"

This reverts commit e130ac7, reversing
changes made to b7f2e3d.
@mrmr1993
Revert "Merge pull request #16167 from MinaProtocol/martin/unify-json…
a40b65a 
…-config-loading"

This reverts commit 0b12932, reversing
changes made to 6df5977.
@mrmr1993
Revert "Merge pull request #16163 from MinaProtocol/martin/remove-pha…
2ceea4d 
…ntom-config"

This reverts commit 6df5977, reversing
changes made to ea896cc.
@mrmr1993
Fixup compilation errors
1bb57d6
@mrmr1993
Stop using commit_id
734b6b4
@mrmr1993
Remove unused parameter
b530663
@mrmr1993
Add missing fields to integration test local engine config
f1bf8fa
@mrmr1993 mrmr1993 requested review from a team as code owners January 29, 2025 00:06
@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member Author

!ci-nightly-me

@mrmr1993 mrmr1993 mentioned this pull request Jan 29, 2025
Open
@mrmr1993
Copy link
Member Author

Nightly run here: https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/3242

@mrmr1993
Copy link
Member Author

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrmr1993