-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flavor] Add Alpha flavor #221
Draft
ScribbleTAS
wants to merge
14
commits into
MinecraftTAS:develop
Choose a base branch
from
ScribbleTAS:enhancement/alpha-flavor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Flavor] Add Alpha flavor #221
ScribbleTAS
wants to merge
14
commits into
MinecraftTAS:develop
from
ScribbleTAS:enhancement/alpha-flavor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note to self: |
e2107bc
to
96a2ad4
Compare
2ead617
to
b805a9d
Compare
c022077
to
48e6ac2
Compare
Was always unsatisfied with the name "integrated"... But I recently took a look at martinvonz/jj and found that they use the name "builtin" and I just had to switch to it...
- [Metadata] Added enum options to CreditsMetadataExtension and StartpositionMetadataExtension for easier retrieval of values
- Add test for alpha flavor - Made some metadata values protected
- [PlaybackSersialiser] Switched from using toString() in keyboard and mouse to the same implementation. Reason is that toString in VirtualKeyboard might change in the fututure while the SerialiserFlavorBase is supposed to be backwards compatible
- Extracted serialiseKeyboardSubtick from serialiseKeyboard - Extracted serialiseMouseSubtick from serialiseMouse - Extracted serialiseCameraAngleSubtick from serialiseCameraAngle - Moved serialiseFileCommands methods further down
- A lot of fixes and changes to get old files to load - Fixed some error messages not displaying the correct values - More tweaks to SerialiserFlavorBase
48e6ac2
to
0cac623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the old alpha format backwards compatible