[Flavor] Add Alpha flavor #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScribbleTAS
added
the
TASFile
|
Note to self: |
ScribbleTAS
force-pushed
the
enhancement/alpha-flavor
branch
from
e2107bc to
96a2ad4
Compare
ScribbleTAS
force-pushed
the
enhancement/alpha-flavor
branch
3 times, most recently
from
2ead617 to
b805a9d
Compare
ScribbleTAS
force-pushed
the
enhancement/alpha-flavor
branch
from
c022077 to
48e6ac2
Compare
Was always unsatisfied with the name "integrated"... But I recently took a look at martinvonz/jj and found that they use the name "builtin" and I just had to switch to it...
- [Metadata] Added enum options to CreditsMetadataExtension and StartpositionMetadataExtension for easier retrieval of values
- Add test for alpha flavor - Made some metadata values protected
- [PlaybackSersialiser] Switched from using toString() in keyboard and mouse to the same implementation. Reason is that toString in VirtualKeyboard might change in the fututure while the SerialiserFlavorBase is supposed to be backwards compatible
- Extracted serialiseKeyboardSubtick from serialiseKeyboard - Extracted serialiseMouseSubtick from serialiseMouse - Extracted serialiseCameraAngleSubtick from serialiseCameraAngle - Moved serialiseFileCommands methods further down
- A lot of fixes and changes to get old files to load - Fixed some error messages not displaying the correct values - More tweaks to SerialiserFlavorBase
ScribbleTAS
force-pushed
the
enhancement/alpha-flavor
branch
from
48e6ac2 to
0cac623
Compare
- Add serialisation to alpha flavor
ScribbleTAS
force-pushed
the
enhancement/alpha-flavor
branch
from
98b1d1e to
1bcddf8
Compare
PancakeTAS
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new file "flavor" to the serialiser, to support the previous file format. This means old files can be imported and even exported to, although with the cost of loosing functionality...
This was also an exercise to actually use the new API, improve it and fix some bugs I encountered in the process...
Of course still not perfect and will probably improved in the future, but for now I want to finish this and work on bugfixing the virtualinput system that has some issues with guis atm...
New
Changes
Fixes