Fix WebSocket URL using wrong config field (baseUrl instead of websocketUrl)#4
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/MineplayMC/atlas-web/sessions/ac5b7cdc-b5dd-46b4-88c4-e62b862af99f Co-authored-by: OmeWillem <94999824+OmeWillem@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
OmeWillem
March 31, 2026 00:32
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2 moved WS URL construction server-side but accidentally used
atlasConfig.baseUrl(the web app's own origin) instead ofatlasConfig.websocketUrl(the Atlas API URL withws:///wss://protocol). This broke all WebSocket functionality. PR #3 kept the same root cause.Change
getWebSocketTokenhandler — swapbaseUrl.replace(/^http/, "ws")forwebsocketUrl, which is already stored at setup time asatlasUrlwith the correct WebSocket protocol:websocketUrlis set during setup asatlasUrl.replace("https://", "wss://").replace("http://", "ws://"), making it the correct base for Atlas API WebSocket connections.