fix: enforce workspace memory limit during extraction - #6149
Merged
timothycarambat merged 4 commits intoAug 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
applyExtractedMemories()limited each extraction batch to 20 workspace memories, but it did not subtract memories already persisted for that workspace. For example, a workspace with 19 memories could receive three new extracted memories and end up with 22, despiteWORKSPACE_LIMITbeing 20.The fix reuses
countForScope()to calculate the remaining workspace slots and only creates that many new memories. Global-memory and update behavior are unchanged.Fixes #6148
Testing
yarn test server/__tests__/models/memory.test.js --runInBand— 1 passedcd server && yarn lint:check— passedAI assistance was used during implementation. I reviewed the final code and regression test and verified the results above locally.