-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests #286
Fix unit tests #286
Conversation
2138ecd
to
ac550df
Compare
ac550df
to
0a871f6
Compare
@nwneisen - on Mac I see the following with and without the PR:
Given Mac is oftentimes used for dev work, I found it worthwhile to mention here in case someone runs into this. |
@vikramhh Mac falls into the unsupported category. Especially since nobody us running a Mac cloud. If someone with a Mac is concerned about it, then they will have to step up and take ownership of supporting Mac. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I am not able to get what the reference to Remove stra method calls
in the PR description is about. You may want to edit it in case there is a typo etc.
Unit tests were not getting ran in CI and so they haven't been getting updated for a while. This PR updates the tests for recent changes that they are now passing.
Proposed Changes
k8s.io/cri-api
so that v1alpha2 can still be used