Skip to content

Conversation

@MisaelMa
Copy link
Owner

@MisaelMa MisaelMa commented Nov 7, 2024

This pull request includes several changes to update the version policies, introduce new configuration options, and refactor existing classes to accommodate these changes. The most important changes include updating the version of the saxon policy, introducing a new Config interface, and refactoring the CFDI and Comprobante classes to use this new configuration.

Version Updates:

  • Updated the saxon policy version from 0.0.16-beta.1 to 12.5.0-beta.1 in common/config/rush/version-policies.json.
  • Updated the @saxon-he/cli package version from 0.0.16-beta.1 to 12.5.0-beta.1 in packages/clir/saxon-he/package.json.

Configuration and Interface Changes:

  • Introduced a new Config interface in packages/cfdi/xml/src/types/types.ts, replacing the Options interface. This new interface includes properties for debug, compact, customTags, schema, saxon, and xslt.

Class Refactoring:

  • Updated the CFDI class in packages/cfdi/xml/src/cfdi.ts to use the new Config interface and added a saxon property. [1] [2] [3] [4]
  • Updated the Comprobante class in packages/cfdi/xml/src/elements/Comprobante.ts to use the new Config interface. [1] [2]

CLI Tool Updates:

  • Refactored the Query and Transform classes in packages/clir/saxon-he/src/query.ts and packages/clir/saxon-he/src/transform.ts to accept an optional binary option in their constructors and removed platform-specific logic for setting the binary path. [1] [2] [3] [4] [5] [6]

@MisaelMa MisaelMa added xml cfdi-xml saxon labels Nov 7, 2024
@MisaelMa MisaelMa changed the title fea(saxon): binary feat(saxon): binary Nov 7, 2024
@MisaelMa MisaelMa merged commit 53b1a48 into beta Nov 7, 2024
@MisaelMa MisaelMa deleted the feat/saxon-binary branch November 7, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

saxon xml cfdi-xml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants