[WIP] Switch default ACL to Deny on the public_ips#664
Open
remibergsma wants to merge 1 commit intomasterfrom
Open
[WIP] Switch default ACL to Deny on the public_ips#664remibergsma wants to merge 1 commit intomasterfrom
remibergsma wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
Test run, this will probably break the load_balancer tests |
borisroman
changed the title
Member
Author
|
Loadbalancer test works fine because it sets |
remibergsma
force-pushed
the
default-deny-as-default-acl-for-public-acl
branch
4 times, most recently
from
bacfed5 to
af2c306
Compare
remibergsma
force-pushed
the
default-deny-as-default-acl-for-public-acl
branch
from
af2c306 to
9c7f560
Compare
remibergsma
changed the title
remibergsma
changed the title
Member
Author
|
TODO: Needs more work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only affects the INPUT chain, so load_balancer and not port_forwards.
It also fixes a bug where the public_ip ACL was not reset at release/associate time. Fixes #674, fixes #676