Skip to content

Save Clayton's Money 💵💵💵 - #424

Merged
ClayJay3 merged 4 commits into
developmentfrom
topic/save-claytons-money
Feb 13, 2026
Merged

Save Clayton's Money 💵💵💵#424
ClayJay3 merged 4 commits into
developmentfrom
topic/save-claytons-money

Conversation

@Byrdman32

Copy link
Copy Markdown
Member

This pull request removes cloning of the LiDAR Submodule hosted via a self-hosted GitLab instance so that Clayton's VPN gets hit with less traffic and as a result saves him money.

@Byrdman32
Byrdman32 requested a review from ClayJay3 February 5, 2026 19:09
@Byrdman32 Byrdman32 self-assigned this Feb 5, 2026
@Byrdman32
Byrdman32 requested a review from a team as a code owner February 5, 2026 19:09
@Byrdman32 Byrdman32 added bug Unexpected behaviors or issues that cause the software to malfunction or produce incorrect results. enhancement Requests for new features or improvements to existing features. 2-Star Indicates a relatively easy task, requiring some basic skills or knowledge but still accessible. formatting Issues related to code formatting, style enforcement, or linting tasks. docker Tasks or issues related to Docker containerization, including Dockerfile configuration and environme actions Tasks or issues related to GitHub Actions or CI/CD automation workflows. cleanup Code refactoring or cleanup tasks to remove deprecated features, improve clarity, or ensure code qua decision Items that require team consensus or decision-making on design, features, or architecture. labels Feb 5, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @Byrdman32, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the build process for development containers by eliminating the automatic cloning of the Autonomy_Software repository and its submodules. This change is intended to significantly reduce network traffic, particularly for self-hosted GitLab instances and associated VPN usage, thereby decreasing operational costs.

Highlights

  • Removed Repository Cloning: The git clone --recurse-submodules command for the Autonomy_Software repository has been removed from both Jammy.dockerfile and JetPack.dockerfile. This change prevents the automatic cloning of this repository and its submodules during the dev container build process.
  • Removed Working Directory Setting: The WORKDIR /opt/Autonomy_Software/ command has been removed from both Dockerfiles, as the Autonomy_Software repository is no longer cloned into that path.
Changelog
  • .devcontainer/Jammy.dockerfile
    • Removed the RUN git clone --recurse-submodules command for Autonomy_Software.
    • Removed the WORKDIR /opt/Autonomy_Software/ command.
  • .devcontainer/JetPack.dockerfile
    • Removed the RUN git clone --recurse-submodules command for Autonomy_Software.
    • Removed the WORKDIR /opt/Autonomy_Software/ command.
Ignored Files
  • Ignored by pattern: .github/workflows/** (8)
    • .github/workflows/clang_check.yml
    • .github/workflows/codeql.yml
    • .github/workflows/coverage.yml
    • .github/workflows/deploy_autonomy.yml
    • .github/workflows/deploy_docker.yml
    • .github/workflows/doxygen_generate.yml
    • .github/workflows/help_requester.yml
    • .github/workflows/tests.yml
Activity
  • No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the git clone command for the Autonomy_Software repository from the devcontainer Dockerfiles. This is a positive change that aligns with best practices for devcontainers, which typically mount the source code from the host instead of baking it into the image. By removing the repository cloning from the Docker build process, you've correctly addressed the issue of unnecessary submodule cloning, which will reduce build times and avoid potential version conflicts. The changes are sound and improve the devcontainer configuration.

@ClayJay3
ClayJay3 merged commit 46deb2c into development Feb 13, 2026
6 of 23 checks passed
@ClayJay3
ClayJay3 deleted the topic/save-claytons-money branch February 24, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2-Star Indicates a relatively easy task, requiring some basic skills or knowledge but still accessible. actions Tasks or issues related to GitHub Actions or CI/CD automation workflows. bug Unexpected behaviors or issues that cause the software to malfunction or produce incorrect results. cleanup Code refactoring or cleanup tasks to remove deprecated features, improve clarity, or ensure code qua decision Items that require team consensus or decision-making on design, features, or architecture. docker Tasks or issues related to Docker containerization, including Dockerfile configuration and environme enhancement Requests for new features or improvements to existing features. formatting Issues related to code formatting, style enforcement, or linting tasks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants