Save Clayton's Money 💵💵💵 - #424
Conversation
Summary of ChangesHello @Byrdman32, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the build process for development containers by eliminating the automatic cloning of the Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the git clone command for the Autonomy_Software repository from the devcontainer Dockerfiles. This is a positive change that aligns with best practices for devcontainers, which typically mount the source code from the host instead of baking it into the image. By removing the repository cloning from the Docker build process, you've correctly addressed the issue of unnecessary submodule cloning, which will reduce build times and avoid potential version conflicts. The changes are sound and improve the devcontainer configuration.
This pull request removes cloning of the LiDAR Submodule hosted via a self-hosted GitLab instance so that Clayton's VPN gets hit with less traffic and as a result saves him money.