Fix parsing bug where includes are skipped #686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSH config parser avoids parsing everything inside a
Host
block that does not match the host we are trying to connect to.This makes sense, but the implementation fails on some cases. Consider the following:
et host.company
And inside
~/.ssh/host.company
we have:The way the parser works now is:
Host other.company
and setsparsing = 0
because it does not match the targethost.company
.Include
completely becauseparsing = 0
.Host host.company
.This PR simply does not ignore
Include
directives to avoid such cases.