Add custom toolchain to generated project#3140
Draft
karim-alweheshy wants to merge 16 commits intoMobileNativeFoundation:mainfrom
Draft
Add custom toolchain to generated project#3140karim-alweheshy wants to merge 16 commits intoMobileNativeFoundation:mainfrom
karim-alweheshy wants to merge 16 commits intoMobileNativeFoundation:mainfrom
Conversation
karim-alweheshy
force-pushed
the
karim/add-custom-toolchain-to-generated-project
branch
from
8655dc5 to
0636a1e
Compare
karim-alweheshy
changed the title
karim-alweheshy
force-pushed
the
karim/add-custom-toolchain-to-generated-project
branch
2 times, most recently
from
17dddeb to
ba560c8
Compare
longsview
reviewed
Mar 24, 2025
| ), | ||
| .init(key: "SWIFT_OBJC_INTERFACE_HEADER_NAME", value: #""""#), | ||
| .init(key: "SWIFT_OPTIMIZATION_LEVEL", value: #""-Onone""#), | ||
| .init(key: "SWIFT_USE_INTEGRATED_DRIVER", value: "NO"), |
Contributor
There was a problem hiding this comment.
awesome ... thanks for cleaning these up in this PR as well.
longsview
reviewed
Mar 24, 2025
| unset toolchain | ||
| fi | ||
| fi | ||
|
|
longsview
approved these changes
Mar 24, 2025
karim-alweheshy
force-pushed
the
karim/add-custom-toolchain-to-generated-project
branch
3 times, most recently
from
bbc7b23 to
93c1f9e
Compare
added 16 commits
July 7, 2025 18:47
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
karim-alweheshy
force-pushed
the
karim/add-custom-toolchain-to-generated-project
branch
from
3fef9e1 to
c782d46
Compare
40 tasks
jeffhodsdon
added a commit
to jeffhodsdon/rules_xcodeproj
that referenced
this pull request
Dec 16, 2025
This commit enables working SwiftUI Previews in Xcode for projects using rules_xcodeproj with BwX (Build with Xcode) mode. Fixes: - Filter LINKED_BINARY= from linker arguments (wrapped_clang specific) - Filter -objc_abi_version malformed arguments (skip 3 args) - Filter -Wl,-objc_abi_version,2 (Xcode sets this itself) - Exclude merged product files from linking to prevent duplicate symbols - Enable ENABLE_DEBUG_DYLIB and ENABLE_DEFAULT_SEARCH_PATHS - Disable custom TOOLCHAINS (causes module issues with previews) - Add ENABLE_DEBUG_DYLIB check to Create Link Dependencies build phase - Unique toolchain names per workspace (prevents conflicts) - Pass through preview-related flags in clang.sh Builds on PRs MobileNativeFoundation#3139 and MobileNativeFoundation#3140. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jeffhodsdon
added a commit
to jeffhodsdon/rules_xcodeproj
that referenced
this pull request
Dec 16, 2025
This commit enables working SwiftUI Previews in Xcode for projects using rules_xcodeproj with BwX (Build with Xcode) mode. Fixes: - Filter LINKED_BINARY= from linker arguments (wrapped_clang specific) - Filter -objc_abi_version malformed arguments (skip 3 args) - Filter -Wl,-objc_abi_version,2 (Xcode sets this itself) - Exclude merged product files from linking to prevent duplicate symbols - Enable ENABLE_DEBUG_DYLIB and ENABLE_DEFAULT_SEARCH_PATHS - Disable custom TOOLCHAINS (causes module issues with previews) - Add ENABLE_DEBUG_DYLIB check to Create Link Dependencies build phase - Unique toolchain names per workspace (prevents conflicts) - Pass through preview-related flags in clang.sh Builds on PRs MobileNativeFoundation#3139 and MobileNativeFoundation#3140.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the custom toolchain to inject a toolchain instead of other user defined settings
Required for SwiftUI