-
Notifications
You must be signed in to change notification settings - Fork 0
feat: typescript 6 update + eslint upgrade + flaky cypress test fix #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
be2544f
updated to Typescript 6 + eslint upgrades
Alessandro100 d6ce829
typecheck eslint rules
Alessandro100 5575b87
lint fixes
Alessandro100 5e69654
cypress update
Alessandro100 7ec6697
cypress fix flaky test by creating user then visit
Alessandro100 022079f
new cypress script for dev
Alessandro100 f967253
updated test values
Alessandro100 a50a6aa
renabled changepassword tests
Alessandro100 51c3619
doc updates and test enabling
Alessandro100 f96fc6b
version bump
Alessandro100 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import js from '@eslint/js'; | ||
| import tseslint from 'typescript-eslint'; | ||
| import next from 'eslint-config-next/core-web-vitals'; | ||
| import prettierRecommended from 'eslint-plugin-prettier/recommended'; | ||
|
|
||
| export default tseslint.config( | ||
| { | ||
| ignores: [ | ||
| 'dist/', | ||
| 'build/', | ||
| 'out/', | ||
| 'node_modules/', | ||
| '.next/', | ||
| 'coverage/', | ||
| '**/*.config.js', | ||
| '**/*.config.mjs', | ||
| 'next-env.d.ts', | ||
| ], | ||
| }, | ||
| js.configs.recommended, | ||
| ...tseslint.configs.recommendedTypeChecked.map((c) => ({ ...c, files: ['**/*.{ts,tsx}'] })), | ||
| // next[1] (next/typescript) is skipped — it re-declares @typescript-eslint, | ||
| // conflicting with tseslint.configs.recommended above, which we use instead | ||
| // for TypeScript 6 compatibility and the full recommended ruleset. | ||
| (({ languageOptions: _lang, ...rest }) => rest)(next[0]), | ||
| next[3], // core-web-vitals: promotes no-html-link-for-pages + no-sync-scripts to errors | ||
| { | ||
| files: ['**/*.{ts,tsx,js,jsx}'], | ||
| languageOptions: { | ||
| parserOptions: { projectService: true }, | ||
| }, | ||
| rules: { | ||
| '@typescript-eslint/no-unused-vars': [ | ||
| 'error', | ||
| { | ||
| vars: 'all', | ||
| args: 'none', | ||
| varsIgnorePattern: '^_', | ||
| caughtErrors: 'none', | ||
| destructuredArrayIgnorePattern: '^_', | ||
| ignoreRestSiblings: true, | ||
| }, | ||
| ], | ||
| // TODO: hooks called inside render callbacks, incorrect hook usage patterns, | ||
| // and missing/extra effect dependencies — to be fixed in a separate ticket. | ||
| 'react-hooks/rules-of-hooks': 'off', | ||
| 'react-hooks/refs': 'off', | ||
| 'react-hooks/set-state-in-render': 'off', | ||
| 'react-hooks/set-state-in-effect': 'off', | ||
| 'react-hooks/immutability': 'off', | ||
| 'react-hooks/exhaustive-deps': 'off', | ||
| // TypeScript handles these; disable the core JS versions. | ||
| 'no-undef': 'off', | ||
| 'no-unused-vars': 'off', | ||
| // Type-checked rules from recommendedTypeChecked that are too noisy | ||
| // for the current codebase — kept off to preserve parity with the | ||
| // previous eslint-config-standard-with-typescript baseline. | ||
| '@typescript-eslint/no-unsafe-assignment': 'off', | ||
| '@typescript-eslint/no-unsafe-member-access': 'off', | ||
| '@typescript-eslint/no-unsafe-argument': 'off', | ||
| '@typescript-eslint/no-unsafe-call': 'off', | ||
| '@typescript-eslint/no-unsafe-return': 'off', | ||
| '@typescript-eslint/no-unsafe-enum-comparison': 'off', | ||
| '@typescript-eslint/no-unnecessary-type-assertion': 'off', | ||
| '@typescript-eslint/no-redundant-type-constituents': 'off', | ||
| '@typescript-eslint/require-await': 'off', | ||
| '@typescript-eslint/no-misused-promises': 'off', | ||
| }, | ||
| }, | ||
| prettierRecommended, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.