Port to 1.21.5 and rework no vote data. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acikek
reviewed
Jan 30, 2025
src/main/java/net/modfest/ballotbox/client/BallotBoxClient.java
Outdated
Show resolved
Hide resolved
src/main/java/net/modfest/ballotbox/client/BallotBoxClient.java
Outdated
Show resolved
Hide resolved
acikek
reviewed
Jan 30, 2025
|
Did you test ballotbox data via a data pack? |
I did! |
|
|
|
Currently testing icons. |
|
|
|
Hi, minor update for this PR. We don't know whether Mod Garden will be running on 1.21.4 or 1.21.5, simply because we don't know when .5 will release. If it releases in like March and if there's enough time to update mods, this PR will be changed to .5, so don't merge until we find out which version we're running on. |
|
I kinda want everything in this PR except the 1.21.4 port - any chance of that? |
Sure! I'll get to it sometime soon! |
# Conflicts: # gradle.properties # libs.versions.toml # src/main/java/net/modfest/ballotbox/BallotBoxPlatformClient.java # src/main/java/net/modfest/ballotbox/client/VotingScreen.java # src/main/java/net/modfest/ballotbox/mixin/client/GameMenuScreenMixin.java # src/main/java/net/modfest/ballotbox/mixin/client/TitleScreenMixin.java
I don't know if this is proper, but considering the port I thought it would be correct to add us as contributors.
|
1.21.5 port complete 🍍 |
MerchantCalico
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies if any file spacing is incorrect due to my IDE settings.
This PR: