Skip to content

GitHub Action btwn QCEl and QCSk#218

Closed
loriab wants to merge 27 commits into
masterfrom
schemalint
Closed

GitHub Action btwn QCEl and QCSk#218
loriab wants to merge 27 commits into
masterfrom
schemalint

Conversation

@loriab

@loriab loriab commented Mar 3, 2020

Copy link
Copy Markdown
Collaborator

Description

Continues from #204. Generate schema from pydantic qcel for models owned by qcsk, compare them, and issue PR to latter in case change to qcel would affect qcsk. Part of MolSSI/QCSchema#68 effort to consolidate single source of truth here and community discussion there.

  • because secrets not passed to PRs from forks, these'll have to be internal PRs. I don't understand how codecov is working from fork PRs.
  • I think this is pretty much ready. the whole sequence is:

Changelog description

Status

  • Code base linted
  • Ready to go

@codecov

codecov Bot commented Mar 3, 2020

Copy link
Copy Markdown

Codecov Report

Merging #218 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@loriab

loriab commented Sep 4, 2020

Copy link
Copy Markdown
Collaborator Author

This has been subsumed into #237

@loriab loriab closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant