Skip to content

provenance default for schema#233

Closed
loriab wants to merge 3 commits into
MolSSI:masterfrom
loriab:mypy_trial
Closed

provenance default for schema#233
loriab wants to merge 3 commits into
MolSSI:masterfrom
loriab:mypy_trial

Conversation

@loriab

@loriab loriab commented Aug 18, 2020

Copy link
Copy Markdown
Collaborator

Description

  • provenance switched to dynamic default so qcel doesn't show in schema. still passes mypy
  • other small mypy fixes
  • necessitates pydantic jump from 1.0 to 1.5

Status

  • Code base linted
  • Ready to go

@codecov

codecov Bot commented Aug 18, 2020

Copy link
Copy Markdown

Codecov Report

Merging #233 into master will decrease coverage by 0.01%.
The diff coverage is 94.73%.

@loriab

loriab commented Sep 4, 2020

Copy link
Copy Markdown
Collaborator Author

This has been subsumed into #237

@loriab loriab closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant