Skip to content

Fix non-development package installation#81

Open
berquist wants to merge 16 commits into
MolSSI:masterfrom
berquist:make-pip-installable
Open

Fix non-development package installation#81
berquist wants to merge 16 commits into
MolSSI:masterfrom
berquist:make-pip-installable

Conversation

@berquist

Copy link
Copy Markdown
Contributor

This depends on #80. It installs the schema files, and CI is set up to test the installed package. In order for this to work, the tests needed to be installed alongside the rest of the package, which is part of cookiecutter "best practices" anyway.

@berquist

Copy link
Copy Markdown
Contributor Author

Without specifying package_data, this works fine with pip in an old-style venv, but not in a conda env, still using pip. It seems independent of setuptools version.

@berquist

Copy link
Copy Markdown
Contributor Author

I cannot figure out why this is passing in GHA but not locally for me, even inside of different Docker containers.

@berquist berquist marked this pull request as ready for review July 25, 2021 01:51
berquist added a commit to berquist/cclib that referenced this pull request Dec 31, 2021
berquist added a commit to berquist/cclib that referenced this pull request Feb 15, 2023
berquist added a commit to berquist/cclib that referenced this pull request Jul 19, 2023
berquist added a commit to berquist/cclib that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant