Feature/transactions screen#32
Open
Ahmedsayed0895 wants to merge 60 commits into
Open
Conversation
Ahmedsayed0895
requested review from
Abdulrahman-Ragab-01,
AdelTamer35,
AhmadKharfan,
HendSayed25,
Joseph-Sameh-0,
YoussefmSaber,
abdo-essam,
ahmeddsamii,
ahmedfikry24,
ahmedmahgoub0,
baraa0abd,
dev-bilal-azzam,
fatmahgazy and
hagarabobakr
YoussefmSaber
left a comment
YoussefmSaber
left a comment
Contributor
There was a problem hiding this comment.
Good work, but check the comments and take in consideration
…ransactionUiState
Comment on lines
+5
to
+7
| class GetCategoriesUseCase(private val repository: CategoryRepository) { | ||
| suspend operator fun invoke() = repository.getCategories() | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
what is the use of this usecase it's just a wrapper, no need for it
Contributor
There was a problem hiding this comment.
for the effect and intent can you referre to this pr, that shows how are we going to use our architecture and code base
Comment on lines
+115
to
+132
| transactions: List<TransactionUiModel>, | ||
| currentState: TransactionUiState.ContentState, | ||
| selectedTransactionType: TransactionUiState.TransactionTypeFilter, | ||
| date: LocalDate, | ||
| listState: LazyListState, | ||
| onDateClick: () -> Unit, | ||
| onFilterClick: () -> Unit, | ||
| allCategories: List<CategoryUiModel>, | ||
| selectedCategoryIds: List<String>, | ||
| showCategoriesFilterBottomSheet: Boolean, | ||
| showDatePickerDialog: Boolean, | ||
| onApplyFilterClick: (List<String>) -> Unit, | ||
| onDismissCategorySheet: () -> Unit, | ||
| onTransactionTypeClick: (TransactionUiState.TransactionTypeFilter) -> Unit, | ||
| onAddTransactionClick: () -> Unit, | ||
| onDateSelected: (LocalDate) -> Unit, | ||
| onDatePickerDialogDismiss: () -> Unit, | ||
| modifier: Modifier = Modifier, |
Contributor
There was a problem hiding this comment.
why all of this, just pass the state, and the viewModel intent and call them inside the code, no need for such thing
Comment on lines
+228
to
+233
| fadeInSpec = tween(300, easing = EaseInExpo), | ||
| fadeOutSpec = tween(300, easing = EaseOutExpo), | ||
| placementSpec = spring( | ||
| dampingRatio = Spring.DampingRatioLowBouncy, | ||
| stiffness = Spring.StiffnessLow | ||
| ) |
Contributor
There was a problem hiding this comment.
for animations, i have already made an animations for our project, you can find it inside the design_system module -> theme -> animations
Comment on lines
+78
to
+104
| tryExecute( | ||
| block = { getTransactionsUseCase(filter) }, | ||
| onStart = { | ||
| updateState { copy(isLoading = true, isError = false) } | ||
| }, | ||
| onSuccess = { transactions -> | ||
| val allTransactions = transactions.map { it.toUiModel() } | ||
| updateState { | ||
| copy( | ||
| allTransactions = allTransactions, | ||
| isLoading = false, | ||
| isError = false | ||
| ) | ||
| } | ||
| applyLocalFilters(newListToFilter = allTransactions) | ||
| }, | ||
| onError = { error -> | ||
| updateState { | ||
| copy( | ||
| isLoading = false, | ||
| isError = true, | ||
| errorMessage = error.message | ||
| ) | ||
| } | ||
| sendEffect(TransactionEffect.ShowSnackbarError(error.message ?: "Unknown Error")) | ||
| } | ||
| ) |
Contributor
There was a problem hiding this comment.
split each function inside the tryExecute to a seperate function, take a look on other prs, we all using this structure, and when call the functions inside the tryExecute call them in order
onStart,
block,
onSuccess,
onError
Comment on lines
+108
to
+122
| tryExecute( | ||
| block = { getCategoriesUseCase() }, | ||
| onSuccess = { categories -> | ||
| updateState { | ||
| copy( | ||
| categories = categories.map { category -> | ||
| category.toUiModel() | ||
| }, | ||
| ) | ||
| } | ||
| }, | ||
| onError = { error -> | ||
| sendEffect(TransactionEffect.ShowSnackbarError(error.message ?: "Unknown Error")) | ||
| } | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat: Implement Transaction Screen
Demo
money++.mp4
Key Features
Related issues: