First pass at a Rust based decentralized ledger #1
Conversation
This reverts commit 49ec8ea.
letsgetrusty
left a comment
letsgetrusty
left a comment
There was a problem hiding this comment.
Overall this looks like a great first pass! The tests make it easier to review the code as well!
| timestamp, | ||
| }; | ||
|
|
||
| let confirmed_transactions = vec![genesis_transaction.clone()].into_iter().collect(); |
There was a problem hiding this comment.
Question: Do you plan on keeping these confirmed transactions in BlockChain?
I'm assuming this is for either testing purposes or intended for the genesis transactions only? If it's the latter, we can probably create a genesis Block with genesis transactions instead, right?
The reason I'm asking is that it feels like duplicated data since we have transactions in Block too.
There was a problem hiding this comment.
confirmed transactions is intended to have all transactions from every block in the chain, solely to facilitate O(1) lookups.
that said - completely separate thing but I'm not entirely sure we need to have any transactions in the genesis block.
The crate contains a lib and bin. All of the logic is in
lib, andbindoesn't do a whole lot quite yet.A somewhat thorough demonstration of the current capabilities can be found in the test in
tests/two_node.rs.