[FEAT] 읽은 책 책장, 책 상세 조회 구현 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gogori6565
reviewed
Dec 19, 2025
Comment on lines
12
to
25
| public class DoneReadBookshelfItemDTO { | ||
| private Long articleId; // 게시글 ID | ||
| private String isbn; // ISBN | ||
| private String title; // 책 제목 | ||
| private String author; // 저자 | ||
| private String bookImage; // 표지 이미지 | ||
| private String publisher; // 출판사 | ||
| private String description; // 책 소개 | ||
| private String pubdate; // 출판연도 | ||
| private Double ratingAverage; // 별점 평균 | ||
| private Integer ratingCount; // 별점 개수 | ||
| private Float weight; // 두께 | ||
| private Float height; // 높이 | ||
| } |
Contributor
There was a problem hiding this comment.
해당 DTO = 읽은 책 책장에 표시되는 책 정보에 대한 DTO로 이해했는데 맞을까요?
맞다면, 읽은 책 책장 페이지에서 필요한 정보는 [도서명, 별점, 두께, 높이, 게시글 ID, {해당 도서로 작성된 게시글 개수}] 인데 다른 정보도 같이 보내주는 이유가 무엇인지 여쭤봐도 될까요?
Comment on lines
106
to
117
| private BookDTO convertToBookDTO(Book book) { | ||
| return BookDTO.builder() | ||
| .isbn(book.getIsbn()) | ||
| .title(book.getTitle()) | ||
| .author(book.getAuthor()) | ||
| .bookImage(book.getBookImage()) | ||
| .publisher(book.getPublisher()) | ||
| .description(book.getDescription()) | ||
| .pubdate(book.getPubdate()) | ||
| .ratingAverage(book.getRatingAverage()) | ||
| .ratingCount(book.getRatingCount()) | ||
| .build(); |
Contributor
There was a problem hiding this comment.
읽고 싶은 책장도 페이지에서 필요로 하는 정보는 [isbn, 책 표지] 뿐인데 기타 정보들도 같이 넘겨주는 이유가 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Related Issue
📝 Summary
📬 Reference
[ 구현한 API ]
