-
-
Notifications
You must be signed in to change notification settings - Fork 29
feat: add de translation #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
and I'm done! Ready for review. |
|
Thank you! This looks great. I asked in the WLED discord german channel if someone could help me review this :) |
|
As a native german speaker, I have tested your branch. The texts look good, but some minor additional changes were needed to integrate and ship the new language with the app. |
|
Since those changes are needed outside of
|
konradmoesch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one typo.
Everything else are just alternate phrasing options, where both (yours and my suggestions) should be fine, I think.
Thanks for the patch, I really like using the app in german:)
|
There's been a lot of changes with my rewrite of the UI and there's some feedback left. @starfetch would you mind revisiting this please? |
|
Hi @Moustachauve, I'll gladly take a look, and thanks @konradmoesch for the review (apologies for completely missing your feedback). |
|
@Moustachauve I have addressed the open feedback (thank you @konradmoesch for being so thorough). I'm not sure how best to proceed with the upstream changes, could you give me a few pointers? |
Hi!
I've started on a German translation for the strings, currently it's still a WIP but should be done soon enough.
Opened this draft PR to avoid possibly doubling the translation efforts.
So far I've created a
values-defolder and added the Englishstrings.xml, now I'm slowly replacing the English strings with the German ones.I hope that this is the correct way to go, if not, happy to change and adjust.