Skip to content

Conversation

@starfetch
Copy link

Hi!
I've started on a German translation for the strings, currently it's still a WIP but should be done soon enough.
Opened this draft PR to avoid possibly doubling the translation efforts.

So far I've created a values-de folder and added the English strings.xml, now I'm slowly replacing the English strings with the German ones.
I hope that this is the correct way to go, if not, happy to change and adjust.

@starfetch starfetch changed the title WIP: de translation feat: add de translation Dec 17, 2023
@starfetch
Copy link
Author

and I'm done! Ready for review.

@starfetch starfetch marked this pull request as ready for review December 17, 2023 18:42
@Moustachauve
Copy link
Owner

Thank you! This looks great. I asked in the WLED discord german channel if someone could help me review this :)

@konradmoesch
Copy link

As a native german speaker, I have tested your branch. The texts look good, but some minor additional changes were needed to integrate and ship the new language with the app.
With those additions, this PR looks LGTM to me

@konradmoesch
Copy link

Since those changes are needed outside of values-de/strings.xml, I will post them here:

  • app/src/main/res/xml/locales_config.xml:
    Add <locale android:name="de"/>
  • app/build.gradle(l.22):
    resourceConfigurations += ['de', 'en', 'fr']

Copy link

@konradmoesch konradmoesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one typo.
Everything else are just alternate phrasing options, where both (yours and my suggestions) should be fine, I think.
Thanks for the patch, I really like using the app in german:)

@Moustachauve
Copy link
Owner

There's been a lot of changes with my rewrite of the UI and there's some feedback left. @starfetch would you mind revisiting this please?

@Moustachauve Moustachauve marked this pull request as draft November 12, 2024 05:40
@starfetch
Copy link
Author

Hi @Moustachauve, I'll gladly take a look, and thanks @konradmoesch for the review (apologies for completely missing your feedback).

@starfetch
Copy link
Author

@Moustachauve I have addressed the open feedback (thank you @konradmoesch for being so thorough). I'm not sure how best to proceed with the upstream changes, could you give me a few pointers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants