-
Notifications
You must be signed in to change notification settings - Fork 29
Accessibility enhancements #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Sorry for the delay but I'm still researching everything about accessibility. I can imagine why it took you so long and it might take me some time as well. Meanwhile, I found some problems that you can deal with. Also, I've not fully researched accessibility and you've probably read about it more than me by now. So, if you disagree with any point, let me know.
|
@vikramj74 Please update your fork and fix the changes. Please keep us updated about the task. Thanks for your work. |
@CuriousLearner Sure, I'll update my fork and keep you guys updated about this. |
Conflicts: index.html src/client/css/style.css
@CuriousLearner I've updated my fork and the conflicts have been fixed. |
@Slayslot Thanks for your review and insights. I'm sorry for the delay in my response . Something urgent came up, so I couldn't work on these issues for a while. Here's my response to your the review points.
I'm still working on the rest and will post the updates here. |
@Slayslot Update : Response to point 3.
|
Try to navigate with tab through their download firefox section, you'll see.
I never knew this. Well, I guess you'll have to turn text-transform off and @h4xr is going to have to deal with it typographically in PR #37. |
Hello, @vikramj74 What's the update with this PR? |
hey @Slayslot ,i want to work on it.please guide. |
Hi, @TheCOsmOLogISt10. Thank you for your interest in this task. Know that this is a pretty huge task in itself. You can take a look at this entire PR and how @vikramj74 was doing things. Also, the problems enlisted by me in his method. Here's some resources for you to take a look at: |
hey @vikramj74,can you update your fork and add me as a contributer,as it would be easy for me to work.Thanks |
Rather than waiting to provide access, why don't you just pull his work on your local and start from there? @TheCOsmOLogISt10 cc @Slayslot |
@TheCOsmOLogISt10 I've added you as a collaborator to the fork. I've not been able to contribute to the fork, for a very long time ( I got very busy in some other things ). I will try to update the fork ASAP, and then you can take it forward from there. Meanwhile, as @CuriousLearner mentioned you may clone the fork and start exploring the code. |
Thanks, @vikramj74 for the help. Let me know if you need any help with updating your fork. |
I've added ARIA markup for making the page more accessible for differently abled persons. Also, I've added support for navigation and UI interaction through keyboard.
Tool used for accessibility testing: NVDA screen reader ( OS : Windows 10 )