Fix panic from empty LeveledMeterProvider (#204)

MrAlias · Sep 29, 2024 · a1e004c · a1e004c
1 parent d052ffd
commit a1e004c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/example_test.go b/example_test.go
@@ -20,9 +20,12 @@ import (
 
 	"github.com/MrAlias/collex"
 	"go.opentelemetry.io/collector/component"
+	"go.opentelemetry.io/collector/config/configtelemetry"
 	"go.opentelemetry.io/collector/exporter"
 	"go.opentelemetry.io/collector/exporter/debugexporter"
 	"go.opentelemetry.io/otel"
+	"go.opentelemetry.io/otel/metric"
+	"go.opentelemetry.io/otel/metric/noop"
 	"go.opentelemetry.io/otel/sdk/trace"
 	"go.uber.org/zap"
 )
@@ -32,6 +35,9 @@ func Example() {
 		TelemetrySettings: component.TelemetrySettings{
 			Logger:         zap.NewExample(), // Log to STDOUT for example.
 			TracerProvider: otel.GetTracerProvider(),
+			LeveledMeterProvider: func(configtelemetry.Level) metric.MeterProvider {
+				return noop.NewMeterProvider()
+			},
 		},
 	}
 	factory, err := collex.NewFactory(debugexporter.NewFactory(), settings)
@@ -53,5 +59,5 @@ func Example() {
 		log.Fatal(err)
 	}
 
-	// Output: {"level":"info","msg":"TracesExporter","#spans":1}
+	// Output: {"level":"info","msg":"TracesExporter","resource spans":1,"spans":1}
 }
diff --git a/factory.go b/factory.go
@@ -18,8 +18,11 @@ import (
 	"context"
 
 	"go.opentelemetry.io/collector/component"
+	"go.opentelemetry.io/collector/config/configtelemetry"
 	"go.opentelemetry.io/collector/exporter"
 	"go.opentelemetry.io/otel"
+	"go.opentelemetry.io/otel/metric"
+	"go.opentelemetry.io/otel/metric/noop"
 	"go.opentelemetry.io/otel/sdk/trace"
 	"go.uber.org/zap"
 )
@@ -45,6 +48,9 @@ func NewFactory(f exporter.Factory, set *exporter.Settings) (*Factory, error) {
 			TelemetrySettings: component.TelemetrySettings{
 				Logger:         logger,
 				TracerProvider: otel.GetTracerProvider(),
+				LeveledMeterProvider: func(configtelemetry.Level) metric.MeterProvider {
+					return noop.NewMeterProvider()
+				},
 			},
 			BuildInfo: component.BuildInfo{
 				Command:     "collex",

diff --git a/go.mod b/go.mod
@@ -37,6 +37,7 @@ require (
 	go.opentelemetry.io/collector/pdata/pprofile v0.110.0 // indirect
 	go.opentelemetry.io/collector/pipeline v0.110.0 // indirect
 	go.opentelemetry.io/otel/metric v1.30.0 // indirect
+	go.opentelemetry.io/otel/sdk/metric v1.30.0 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
 	golang.org/x/net v0.29.0 // indirect
 	golang.org/x/sys v0.25.0 // indirect