Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow : in bundle names #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Natureshadow
Copy link

This is needed e.g. for rollup-plugin-virtual, which prefixes bundle names with virtual:.

Relevant standard: https://www.rfc-editor.org/rfc/rfc3986#section-4.2

A path segment that contains a colon character (e.g., "this:that")
cannot be used as the first segment of a relative-path reference, as
it would be mistaken for a scheme name. Such a segment must be
preceded by a dot-segment (e.g., "./this:that") to make a relative-
path reference.

This is needed e.g. for rollup-plugin-virtual, which prefixes bundle
names with `virtual:`.

Relevant standard: https://www.rfc-editor.org/rfc/rfc3986#section-4.2

> A path segment that contains a colon character (e.g., "this:that")
> cannot be used as the first segment of a relative-path reference, as
> it would be mistaken for a scheme name.  Such a segment must be
> preceded by a dot-segment (e.g., "./this:that") to make a relative-
> path reference.
@Natureshadow
Copy link
Author

@MrBin99 A timely merge and release to PyPI would be most appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant