Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Bug fixes #660

Merged
merged 3 commits into from
Jan 5, 2025
Merged

🐞 Bug fixes #660

merged 3 commits into from
Jan 5, 2025

Conversation

SenpaiHunters
Copy link
Collaborator

This PR aims to fix #658, #634, #638.

@SenpaiHunters SenpaiHunters requested a review from MrKai77 January 4, 2025 12:44
@SenpaiHunters SenpaiHunters self-assigned this Jan 4, 2025
This was linked to issues Jan 4, 2025
🐞 Setting a keybind that includes a modifier key may omit the modifier key at random #634
Closed
🐞 activate window fail #638
Closed
MrKai77
MrKai77 approved these changes Jan 5, 2025
View reviewed changes
Copy link
Owner

@MrKai77 MrKai77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes in Keycorder to re-add functionality to support more than one non-modifier key. Also removed sorting the modifier keys for as it is a Set.

@MrKai77 MrKai77 merged commit 9107745 into develop Jan 5, 2025
1 check passed
@MrKai77 MrKai77 deleted the fix-bugs branch January 5, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKai77 MrKai77 MrKai77 approved these changes

Assignees

@SenpaiHunters SenpaiHunters

Labels
Bug
Projects
None yet
Milestone
No milestone
2 participants
@SenpaiHunters @MrKai77