Repository navigation
Export PR comparisons without scanner configuration - #6
Merged
Merged
Conversation
MrLesk
added a commit
to MrLesk/groma.md
that referenced
this pull request
Oct 11, 2026
Update the main package dependencies and use Bun 1.4.3 for development and all Bun workflows. Adapt Groma's terminal lifecycle to OpenTUI 0.6.0 so selecting a welcome action waits for terminal suspension, and closing a terminal view waits for restoration before streams are reused or the next welcome screen opens. | Package | Before | After | | --- | --- | --- | | `@opentui/core` | 0.5.12 | 0.6.0 | | `ignore` | 7.0.10 | 7.0.12 | | `@biomejs/biome` | 2.5.14 | 2.5.15 | | `@types/node` | 26.6.2 | 26.6.5 | | `typescript` | 7.1.0-dev.20260924.1 | 7.1.0-dev.20261011.1 | Welcome now awaits `suspend()` before exposing an action. Its CLI owner awaits session cleanup before reopening. The map returns OpenTUI's `renderer.closed` directly, removing its separate early completion promise. Standalone scanner settings and viewer setup failures also await terminal restoration. Scanner, example, and other workspace package files and versions are unchanged. Keep workspace links, the Parcel watcher patch, and the existing TypeScript compiler families. Root TypeScript uses the newest preview in its existing 7.1 family; the lockfile retains the scanner's previous compiler separately. Other root packages already match latest stable releases, and `@types/bun` 1.4.2 remains latest published. Release checks: [OpenTUI breaking changes](https://github.com/anomalyco/opentui/releases/tag/v0.6.0), [ignore patch changes](kaelzhang/node-ignore@7.0.10...7.0.12), [Biome 2.5.15](https://github.com/biomejs/biome/releases/tag/@biomejs%2Fbiome@2.5.15). Existing framebuffer and palette APIs continue to work; no unrelated Bun features or new architecture concepts are introduced. Validation on macOS arm64 with Bun 1.4.3: - Three concurrent lifecycle regressions failed before the fix and passed afterward: welcome suspension, welcome close, and map close must wait for their transitions. - `bun run check`: 16 Node tests and 779 Bun tests passed; 51 optional scanner/package tests skipped, zero failures. - `bun install --frozen-lockfile`: no changes. Standalone build passed. - Compiled `tui-test` checks passed: welcome → settings child → welcome → quit; map root → container → arrow selection → details → 200×60 resize → Ctrl+C. Screenshots were visually checked. - Scanner/example files remain unchanged; `git diff --check` passed and `groma/` is unchanged. Also pin the architecture comparison action to [groma.md-action PR #6](MrLesk/groma.md-action#6), commit `b5eb98ce51df144ba276182a5b80a7a2ce6d11a3`. Comparison preparation no longer requires `scanners.json`; export reads committed architecture and source from an empty temporary working root without loading project scanner hooks or changing configuration. The released scan path stays unchanged until the plugin CLI is released. Action validation: all 26 tests and both GitHub Check runs pass. Real exports pass with Groma 0.6.6 and the plugin-branch CLI, including the exact commits that previously failed in PR #118. Because comparison runs use `pull_request_target`, this pin takes effect after this PR is merged. Tracks TASK-579.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR comparisons failed during preparation when the checked-out branch used
plugins.jsoninstead ofscanners.json, as in MrLesk/groma.md#118. Comparison preparation now skips scan configuration, and export runs in an empty temporary working root connected to the existing Git repository. It reads both committed snapshots without loading project scanner hooks or rewriting project settings.The published scan-and-export path keeps its current CLI and commands until the plugin CLI from MrLesk/groma.md#117 is released.
Validation:
npm run check: 26 tests passed. The three comparison regressions failed before the fix and pass afterward.plugins.jsonremained unchanged.3b9be405to1b737ef8, two components added and sixteen modified.plugins.jsonand noscanners.json.