Repository navigation
Require manual architecture comparisons for external PRs - #115
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Groma architecture comparison
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External fork PRs no longer export architecture automatically. Maintainers can review a PR, then choose Groma architecture → Run workflow on
mainand enter its number. Same-repository PRs remain automatic; the manual choice applies to one run.Comparison jobs keep the trusted base checked out and fetch the PR head only as Git data, so checkout v7 protection remains enabled. The workflow selects Groma 0.6.6 explicitly through the tested Action version input. README and contributor instructions explain the workflow and reader upgrades.
Validation:
bun run checkpasses (773 Bun tests, 51 optional skips, plus Node/lint/type checks). The released 0.6.6 CLI exported #113 from a trusted main checkout. The selection command excludes #113 by default and includes its exact head/base when selected manually. Action integration passes with a base checkout and a different exported head.Action change: MrLesk/groma.md-action#5